Ensure variable syntax before matching in VariableHasSpacesRule (#535)

ansible · Jun 7, 2019 · 69f5e96 · 69f5e96
1 parent e73fb6c
commit 69f5e96
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/ansiblelint/rules/VariableHasSpacesRule.py b/lib/ansiblelint/rules/VariableHasSpacesRule.py
@@ -13,7 +13,10 @@ class VariableHasSpacesRule(AnsibleLintRule):
     tags = ['formatting']
     version_added = 'v4.0.0'
 
+    variable_syntax = re.compile(r"{{.*}}")
     bracket_regex = re.compile(r"{{[^{' -]|[^ '}-]}}")
 
     def match(self, file, line):
+        if not self.variable_syntax.search(line):
+            return
         return self.bracket_regex.search(line)
diff --git a/test/TestVariableHasSpaces.py b/test/TestVariableHasSpaces.py
@@ -31,6 +31,10 @@
 - name: bad variable format
   debug:
     msg: "{{bad_format }}"
+- name: not a jinja variable
+  debug:
+    msg: "test"
+  example: "data = ${lookup{$local_part}lsearch{/etc/aliases}}"
 '''