Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Enable wsl1 testing using npm pipeline #212

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Feb 4, 2022

This is creating a new pipeline because i found the ci.yml very hard to update due to its 1000 lines of code but if someone can take these changes and apply them to ci.yml, I would not mind at all.

@ssbarnea ssbarnea force-pushed the ci/wsl branch 2 times, most recently from 0472420 to e71d6b1 Compare February 5, 2022 16:05
@ssbarnea ssbarnea force-pushed the ci/wsl branch 12 times, most recently from 42c8533 to c39a483 Compare February 6, 2022 09:47
@ssbarnea ssbarnea force-pushed the ci/wsl branch 10 times, most recently from ed8d7b5 to 919df8b Compare February 7, 2022 14:52
@ssbarnea ssbarnea mentioned this pull request Feb 8, 2022
@ssbarnea ssbarnea changed the title WIP: explore wsl1 for testing non-ee use-case Enabled wsl1 testing using npm pipeline Feb 8, 2022
@ssbarnea ssbarnea changed the title Enabled wsl1 testing using npm pipeline Enable wsl1 testing using npm pipeline Feb 8, 2022
@ssbarnea ssbarnea requested review from ganeshrn and webknjaz February 8, 2022 11:21
@ssbarnea ssbarnea marked this pull request as ready for review February 8, 2022 11:23
@ssbarnea ssbarnea requested review from tomaciazek and a team as code owners February 8, 2022 11:23
@webknjaz webknjaz self-assigned this Feb 8, 2022
@webknjaz
Copy link
Member

webknjaz commented Feb 8, 2022

Taking over. I'll merge this into the main workflow and make sure that the bugs introduced are taken care of.

@ssbarnea
Copy link
Member Author

ssbarnea commented Feb 8, 2022

Taking over. I'll merge this into the main workflow and make sure that the bugs introduced are taken care of.

I am happy to see you taking this over. As long we endup with the same outcome (use of wsl pipeline) we should be fine.

While doing the surgery on ci.yml, please keep in mind that we may still need add a classic Windows pipeline in the future (non-wsl), one that tests that we are able to emit a meaningful error message when run in an unsupported environment, example #195

@ssbarnea ssbarnea merged commit 20b628e into ansible:main Mar 2, 2022
@ssbarnea ssbarnea deleted the ci/wsl branch March 2, 2022 09:02
@ssbarnea
Copy link
Member Author

ssbarnea commented Mar 2, 2022

It should be noted that this was needed after more than 3 weeks of waiting.

I would expect @webknjaz to remove this workflow file as part of his integrating with existing pipeline whant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants