config: failback on "nop" if provider is not available #1509
Conversation
Failback on the `nop` provider if the requested provider is not available. This way, the service can start despite the misconfiguration. Another approch is to "fail fast" and raise a critical exception with a clear message to let the user fix the configuration.
|
Draft because there is no test yet and overall I want to discuss this with @manstis first. |
|
Hmm. I'll look properly tomorrow but the fallback to |
|
|
If I remember correctly I (should be) creating the |
|
@goneri if you can find time to mention how to reproduce the issue I'd like to look before you arrive tomorrow. Thanks. |
It happens if I see the provider of ChatBot to |
|
@goneri OK.. so I looked and looked.. but could not find anything that was, or could have been, doing what I thought. Your PR therefore seems fine to me - thanks for identifying the problem and providing a fix. I did create a similar fix that ensures people won't need to worry about the safety of I'll leave it to you to decide which you prefer (but if you could fix this in your PR it'd be appreciated). |
Failback on the
nopprovider if the requested provider is not available. This way,the service can start despite the misconfiguration.
Another approch is to "fail fast" and raise a critical exception with a clear message
to let the user fix the configuration.