Adds tests for role generation anonymization #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manstis
previously approved these changes
Jan 22, 2025
…ady handled by anonymize_struct in the call above
…iterating over each file
2e1e20b to
fa115b6
Compare
|
goneri
approved these changes
Jan 22, 2025
|
Looks good. It could have been a bit more elegant to move the large block of code in a dedicated PR. This remains a welcome change :-). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue: https://issues.redhat.com/browse/AAP-36664
Description
Primarily adding unit tests for code that was already in place. I did add some logic that anonymizes the content of the files though which is net-new. I did move all of the role gen view related tests out to a separate file since test_views.py is massive. I plan on peeling all of the other view related tests out into separate files in the near future to match (as long as there are no objections)
Testing
Primarily executing the unit tests as that's where most of the changes were.