Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wca: allow AAP user without organization_id #1073

Merged
merged 1 commit into from
May 29, 2024
Merged

wca: allow AAP user without organization_id #1073

merged 1 commit into from
May 29, 2024

Conversation

goneri
Copy link
Contributor

@goneri goneri commented May 28, 2024

No description provided.

@goneri goneri mentioned this pull request May 28, 2024
Merged
@goneri goneri requested a review from manstis May 28, 2024 23:23
jameswnl
jameswnl reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@jameswnl jameswnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests

@goneri goneri force-pushed the goneri/wca-allow-AAP-user-without-organization_id_358 branch 2 times, most recently from 2d88477 to 871c8d1 Compare May 29, 2024 00:09
@goneri goneri requested a review from jameswnl May 29, 2024 00:09
@goneri goneri force-pushed the goneri/wca-allow-AAP-user-without-organization_id_358 branch from 871c8d1 to a609c02 Compare May 29, 2024 00:14
manstis
manstis approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The tests arguably are not testing playbook generation per se but do cover the code change.

@goneri
Copy link
Contributor Author

goneri commented May 29, 2024

LGTM 👍

The tests arguably are not testing playbook generation per se but do cover the code change.

Yes is already a test in the class that cover the playbook generation. The new ones are indeed here just to cover this new lines.

@goneri goneri merged commit 40af362 into main May 29, 2024
9 checks passed
@goneri goneri deleted the goneri/wca-allow-AAP-user-without-organization_id_358 branch May 29, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manstis manstis manstis approved these changes

@jameswnl jameswnl Awaiting requested review from jameswnl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goneri @manstis @jameswnl