Skip to content

Commit

Permalink
move pr deployment cluster hostname to secrets
Browse files Browse the repository at this point in the history
  • Loading branch information
jameswnl committed May 29, 2024
1 parent 50502fd commit c715e1e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pr_deployment_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
pull-requests: write
needs: deployment_ready
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Trigger tests on PR deployment
id: test_pr
run: |
Expand All @@ -32,5 +32,5 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Wait for PR deployment completion
run: bash ./.github/workflows/scripts/pr_deployment_test.sh wait_for_pr_deployment ${{ github.event.number }}
run: bash ./.github/workflows/scripts/pr_deployment_test.sh wait_for_pr_deployment ${{ github.event.number }} ${{ secrets.PR_DEPLOY_CLUSTER_HOSTNAME }}
shell: bash
3 changes: 2 additions & 1 deletion .github/workflows/scripts/pr_deployment_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@ invoke_pr_test() {
wait_for_pr_deployment() {
#############################
PR_NUMBER=$1
CLUSTER_HOST=$2
echo "wait_for_pr_deployment: PR_NUMBER=${PR_NUMBER}"
URL="https://wisdom-service-wisdom-pr-${PR_NUMBER}.apps.stage2-west.v2dz.p1.openshiftapps.com/check/"
URL="https://wisdom-service-wisdom-pr-${PR_NUMBER}.apps.${CLUSTER_HOST}/check/"
# URL=https://stage.ai.ansible.redhat.com/check/
for i in {1..16} # 8 minutes shouid be enough
do
Expand Down

0 comments on commit c715e1e

Please sign in to comment.