Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule 1.4.1 typo and doesn't work unless lines already exist (cis_2.0.1 branch) #88

Closed
dderemiah opened this issue Sep 9, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@dderemiah
Copy link
Contributor

Describe the Issue
Fails to create a bootloader line on fresh installs where the line doesn't already exist

Expected Behavior
Should create the bootloader line even if the entries are not there yet

Actual Behavior

Control(s) Affected
1.4.1 Ensure bootloader password

Environment (please complete the following information):

  • Ansible Version: ansible [core 2.15.2]
  • Host Python Version: Python 3.8.10
  • Ansible Server Python Version: Python 3.10.12
  • Additional Details: branch is cis_2.0.1

Additional Notes
Anything additional goes here

Possible Solution
Enter a suggested fix here

@dderemiah dderemiah added the bug Something isn't working label Sep 9, 2023
@uk-bolly uk-bolly self-assigned this Sep 19, 2023
@uk-bolly uk-bolly linked a pull request Sep 25, 2023 that will close this issue
uk-bolly added a commit that referenced this issue Sep 25, 2023
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
This was referenced Sep 25, 2023
@uk-bolly
Copy link
Member

uk-bolly commented Sep 25, 2023

hi @dderemiah

Thank you for raising this issue, apologies for the time it has taken to get addressed. We believe it the fix has now been applied and merged today.
Please let us know if this is still an issue?

many thanks

uk-bolly

dderemiah added a commit to dderemiah/UBUNTU20-CIS that referenced this issue Sep 25, 2023
Signed-off-by: Dan D <daniel.deremiah@windriver.com>
@uk-bolly
Copy link
Member

hi @dderemiah

Thank you for following this up again, i have a greater understanding of your issue now the PR is raised. I don't experience the problem with a standard build.
I am rerunning the pipeline and going to replicate your issue to ensure it covers off all eventualities.

thanks

uk-bolly

dderemiah added a commit to dderemiah/UBUNTU20-CIS that referenced this issue Sep 26, 2023
Signed-off-by: Dan D <daniel.deremiah@windriver.com>
dderemiah added a commit to dderemiah/UBUNTU20-CIS that referenced this issue Sep 26, 2023
Signed-off-by: Dan D <daniel.deremiah@windriver.com>
uk-bolly added a commit that referenced this issue Sep 27, 2023
adds superusers and fixes issue #88
@uk-bolly
Copy link
Member

hi @dderemiah

Have managed to fix the issue with the pipeline and all is now merged into devel. Thank you again fr your feedback and PR.

uk-bolly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants