Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate cluster_ha module from community #106

Merged

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

Migrating vmware_ha_cluster from community to here. The functionality should be the same, but the inputs and outputs are slightly different. Theres a ton of options in this module; I did my best trying to cover them in the test cases but I am not sure how to programmatically validate some of the functionality.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

cluster_ha

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 18.33333% with 196 lines in your changes missing coverage. Please review.

Project coverage is 27.51%. Comparing base (15b4a74) to head (2a2d626).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/cluster_ha.py 18.33% 196 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   28.39%   27.51%   -0.88%     
==========================================
  Files          33       34       +1     
  Lines        2511     2751     +240     
  Branches      453      517      +64     
==========================================
+ Hits          713      757      +44     
- Misses       1798     1994     +196     
Flag Coverage Δ
sanity 27.51% <18.33%> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemorency mikemorency merged commit 5d1f0b9 into ansible-collections:main Jan 28, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants