Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditional error message for speed configuration in sonic_interfaces #470

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented Oct 15, 2024

SUMMARY

I removed the conditional error message for speed configuration because it was incorrectly restricting speed configuration.

GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

GitHub Issue #467
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sonic_interfaces

OUTPUT

regression-2024-10-15-16-12-55.html.pdf
Failing playbook before fixing bug:
failing_playbook.log
Passing playbook after fixing bug:
passing_playbook.log

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at previous code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

@stalabi1 stalabi1 added the bug Something isn't working label Oct 15, 2024
@stalabi1 stalabi1 requested a review from kerry-meyer as a code owner October 15, 2024 23:26
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks fine.

I am requesting a change in the changelog fragment to make it easier for customers to see what is being changed with this PR.

Co-authored-by: Kerry Meyer <kerry.meyer@dell.com>
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change. The revised change set and test results look good.

Approved.

@kerry-meyer kerry-meyer merged commit e02affe into ansible-collections:main Oct 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants