-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the 'auditd-system' message_type choice to the logging resource module #459
Add the 'auditd-system' message_type choice to the logging resource module #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes in code and tests and the corresponding test results look good.
I have posted only a couple of minor change request comments (documentation only; no re-testing needed).
After addressing these comments, please resync your fork and this PR branch to eliminate the merge conflict that is currently flagged on this PR.
Thank you for your work to add Ansible support for the new auditd-system logging message type.
@@ -0,0 +1,2 @@ | |||
minor_changes: | |||
- sonic-logging - Add new 'message_type' choice to the logging resource module (https://github.com/ansible-collections/dellemc.enterprise_sonic/pull/459) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe the new choice here and add the required '.' at the end of the fragment:
- sonic-logging - Add new 'message_type' choice to the logging resource module (https://github.com/ansible-collections/dellemc.enterprise_sonic/pull/459) | |
- sonic-logging - Add new 'auditd_system' choice to the 'message_type' choices for the logging resource module (https://github.com/ansible-collections/dellemc.enterprise_sonic/pull/459). |
@@ -198,7 +199,7 @@ | |||
remote_port: 622 | |||
protocol: TCP | |||
source_interface: Ethernet24 | |||
message_type: audit | |||
message_type: auditd-system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please show the corresponding changed result containing auditd-system in the "After state" display for this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the additional incremental changes.
All of the current proposed changes and test results look good.
Approved.
SUMMARY
Add new 'message_type' choice to the logging resource module.
GitHub Issues
"N/A".
ISSUE TYPE
COMPONENT NAME
sonic_logging
OUTPUT
Ansible Report:
new_message_type.pdf
Raw Regression Test Output:
add_new_message_type.txt
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration