Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] Update replaced state handling #388

Conversation

ArunSaravananBalachandran
Copy link
Collaborator

@ArunSaravananBalachandran ArunSaravananBalachandran commented Jun 6, 2024

SUMMARY

Incorporate the below changes in sonic_system module:

  • Update replaced state handling.
  • Update UT cases.
GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

GitHub Issue #
N/A
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • sonic_system
OUTPUT
ADDITIONAL INFORMATION
Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Regression report: system_regression_report.pdf

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All proposed code changes and corresponding test results look good.

Thank you for fixing the problems with 'replaced' state handling. Thanks also for consolidating and reorganizing this code to reduce redundant instruction sequences, minimize execution time, and improve the readability and maintainability of this code.

Approved.

@kerry-meyer kerry-meyer merged commit 2793017 into ansible-collections:main Jun 18, 2024
16 checks passed
@ArunSaravananBalachandran ArunSaravananBalachandran deleted the system_replace_state branch October 12, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants