Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CoPP module states implementation bug #381

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented May 10, 2024

SUMMARY
  • Fixed the state implementation bugs in the config file and made minor updates to other files
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sonic_copp

OUTPUT

regression-2024-06-06-13-52-06.html.pdf
diff_output.log

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

@stalabi1 stalabi1 requested a review from kerry-meyer as a code owner May 10, 2024 23:27
@mingjunzhang2019 mingjunzhang2019 self-requested a review June 4, 2024 21:06
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good.

I have posted only one minor comment.

I was unable to read the posted regression results. Please add a new enclosure for that.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for posting a new version of the test results and addressing the comment I posted.

All proposed code changes and corresponding test results look good.

Thank you for noticing and fixing these problems in the code.

Approved.

@kerry-meyer kerry-meyer merged commit dc8d814 into ansible-collections:main Jun 7, 2024
16 checks passed
@stalabi1 stalabi1 deleted the fix_copp_bug branch July 10, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants