zabbix_authentication - fix inability to update passwd_check_rules #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
+ Coverage 76.29% 78.10% +1.81%
==========================================
Files 45 45
Lines 5619 5641 +22
Branches 1423 1427 +4
==========================================
+ Hits 4287 4406 +119
+ Misses 836 768 -68
+ Partials 496 467 -29 ☔ View full report in Codecov by Sentry. |
|
Working on fixes for 6.0. |
BGmot
reviewed
Sep 6, 2024
|
|
||
| - name: Set the login result based on current zabbix version | ||
| set_fact: | ||
| login_result: "{{ check_login_under64_result if zabbix_version is version('6.4', '<') else check_login_result }}" |
There was a problem hiding this comment.
Where do you set check_login_result first time for >= 6.4?
There was a problem hiding this comment.
It's defined in the setup_zabbix tests that run before module integration tests.
BGmot
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
zabbix_authentication - fix inability to update passwd_check_rules
ISSUE TYPE
COMPONENT NAME
zabbix_authentication
ADDITIONAL INFORMATION
See the added integration tests for steps on how to reproduce