Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_custom_attribute: Enhance custom attribute management #2343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbaerlocher
Copy link

SUMMARY

Enhance the VMware custom attribute management module by extending supported object types and refactoring code for better maintainability and error handling. These improvements ensure that the module can handle additional object types (such as "Network" and "VirtualApp") and that the code is more modular and robust for future enhancements.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_custom_attribute

ADDITIONAL INFORMATION

The changes include:

  • Extended Object Types:
    Added support for "Network" and "VirtualApp" to cover a broader range of vSphere objects.
  • Code Refactoring:
    • Introduced a helper function for mapping object types, which enhances modularity and eases future extensions.
    • Improved input validation and error handling to increase overall robustness.
    • Modernized the code with Type Hints and comprehensive Docstrings for better readability and maintainability.

These enhancements improve the functionality and maintainability of the module without introducing any breaking changes.

@sbaerlocher sbaerlocher changed the title feat(vmware_custom_attribute): Enhance custom attribute management¨ feat(vmware_custom_attribute): Enhance custom attribute management Mar 5, 2025
@sbaerlocher sbaerlocher force-pushed the feature/refactor-vmware-custom-attribute branch from 2bc2625 to 98cecd4 Compare March 5, 2025 17:08
@sbaerlocher sbaerlocher force-pushed the feature/refactor-vmware-custom-attribute branch from 98cecd4 to e3387d5 Compare March 5, 2025 19:01
@sbaerlocher sbaerlocher changed the title feat(vmware_custom_attribute): Enhance custom attribute management vmware_custom_attribute: Enhance custom attribute management Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant