Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRS Override - add state argument #2342

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Rogacz
Copy link

@Rogacz Rogacz commented Mar 5, 2025

SUMMARY

Added new state attribute with absent, disabled, enabled options to support missing functionality.
You can now remove existing DRS override or set DRS Override to disabled, which is different from manual.

Also added improvements:

  • Add name, uuid, moid, options to find VM in same standard as used in other modules, with optional folder, datacenter, use_instance_uuid arguments
  • Added alias vm_name to name argument to keep backward compatibility
  • Actually support check_mode as it was ignored previously
  • Properly handle editing and removal of existing DRS override entry
  • Expand description
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_drs_override

ADDITIONAL INFORMATION

At work, I need to create and remove DRS override for VMs, so here is an improved version of the module.

Rogacz added 2 commits March 4, 2025 20:43
Add absent option, Switch to find vm based on standard options, Actually support check_mode
separate state argument with new disabled option, improve description
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/150ee2f3859d4fa59078586284c5d5d6

⚠️ ansible-tox-linters CANCELED
build-ansible-collection FAILURE in 4m 39s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant