Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Make find_obj() a PyVmomi method #2318

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[WIP] Make find_obj() a PyVmomi method #2318

wants to merge 13 commits into from

Conversation

mariolenz
Copy link
Collaborator

@mariolenz mariolenz commented Feb 16, 2025 •
edited
Loading

SUMMARY

I think we should make find_obj() a method of the PyVmomi class.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • plugins/module_utils/vmware.py
  • vmware_custom_attribute_manager
  • vmware_dvswitch_info
  • vmware_guest
  • vmware_guest_disk
  • vmware_host_datastore
  • vmware_host_facts
  • vmware_host_snmp
  • vmware_object_custom_attributes_info
  • vmware_object_role_permission
  • vmware_object_role_permission_info
  • vmware_vm_config_option
ADDITIONAL INFORMATION

eddiehavila#1

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/033afe5f7ee14de580b381aa6e03e349

✔️ ansible-tox-linters SUCCESS in 4m 33s
✔️ build-ansible-collection SUCCESS in 7m 36s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 FAILURE in 10m 17s
✔️ ansible-galaxy-importer SUCCESS in 5m 13s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/fae54b467b7a4a558987f2f6ecf439b2

❌ ansible-tox-linters FAILURE in 4m 26s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/8506a093171849e9a2c03ac1aa16276a

❌ ansible-tox-linters FAILURE in 4m 28s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7f91f3eb11df4d9893481fb704cc34e6

❌ ansible-tox-linters FAILURE in 4m 40s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a823adb5ed8c4490b0b9f67b56db6e8d

✔️ ansible-tox-linters SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 8m 56s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 FAILURE in 11m 11s
✔️ ansible-galaxy-importer SUCCESS in 5m 11s

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/dc6ffe7fa05a46ee873ce9c353580e5f

✔️ ansible-tox-linters SUCCESS in 4m 14s
✔️ build-ansible-collection SUCCESS in 7m 23s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 16m 48s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 13m 41s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 44m 08s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 58m 10s
✔️ ansible-galaxy-importer SUCCESS in 4m 46s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/df23671adda24e3d96d2aa5d1203cf29

✔️ ansible-tox-linters SUCCESS in 4m 29s
✔️ build-ansible-collection SUCCESS in 7m 32s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 10m 53s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 20s

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3a4bd67923a24d218d8f46b85692c895

✔️ ansible-tox-linters SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 7m 25s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 19m 53s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 18m 58s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 52m 39s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 1h 03m 25s
✔️ ansible-galaxy-importer SUCCESS in 4m 36s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6bc1b24e359d4d2892ff6b40113590d8

❌ ansible-tox-linters FAILURE in 5m 02s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d7367959dee04a479c982730065841e0

✔️ ansible-tox-linters SUCCESS in 5m 11s
✔️ build-ansible-collection SUCCESS in 7m 50s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 21m 58s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 18m 12s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 59m 02s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 1h 11m 31s
✔️ ansible-galaxy-importer SUCCESS in 4m 26s

@mariolenz
Copy link
Collaborator Author

I'm not sure what to do about vmware_guest_cross_vc_clone and vmware_guest_instant_clone. Those two modules look tricky to me :-/

@ihumster Do you have a good idea? I don't have one ATM...

@mariolenz mariolenz mentioned this pull request Feb 20, 2025
Merged
@mariolenz
Copy link
Collaborator Author

@ihumster I might have an idea about vmware_guest_cross_vc_clone and vmware_guest_instant_clone, but I'm not sure yet. Let me work a bit on this...

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 21, 2025
@mariolenz
vmware_migrate_vmk: Inherit from PyVmomi (#2324)
d3d0575 
SUMMARY
It feels wrong that this module uses vmware.connect_to_api directly. I think it would be better to inherit from / sub-class PyVmomi
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vmware_migrate_vmk
ADDITIONAL INFORMATION
#2318
@mariolenz mariolenz mentioned this pull request Feb 21, 2025
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 23, 2025
@mariolenz
vmware_vm_vss_dvs_migrate: Inherit from PyVmomi (#2325)
2d71d7c 
SUMMARY
It feels wrong that this module uses vmware.connect_to_api directly. I think it would be better to inherit from / sub-class PyVmomi
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vmware_vm_vss_dvs_migrate
ADDITIONAL INFORMATION
#2318
#2324
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e34ffc86424843218512a1dea84a458b

✔️ ansible-tox-linters SUCCESS in 4m 53s
✔️ build-ansible-collection SUCCESS in 5m 54s
✔️ ansible-galaxy-importer SUCCESS in 5m 38s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@mariolenz mariolenz added WIP Work in progress and removed mergeit labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mariolenz