feat(vmware_guest_snapshot): make module compatible with ESXi hosts w…

[hoppla20]

SUMMARY

Due to the current restriction that the datacenter paramter is required, the vmware_guest_snapshot module is not compatible with ESXi hosts without vCenter, even though ESXi with license also exposes this API. This PR removes the restriction of requiring the datacenter parameter and removes the vCenter part from the module description.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vmware_guest_snapshot

ADDITIONAL INFORMATION

This change was tested against an ESXi 7.0 Update 3 host (with license) without a vCenter.

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d9dc86ebaadd4c03bd4cf21286ed4bd3

✔️ ansible-tox-linters SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 7m 35s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable218 FAILURE in 16m 34s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 10s

[hoppla20]

I will check on the tests later, I havn't checked the implications of this change when using it against a vCenter

[hoppla20]

So I have tested the change on a vCenter 7 and it should be working. This PR also doesn't change how this module functions. It only makes the datacenter argument optional and updates the module description.

I have also checked the failing test and I don't see any reason why this PR should have any effect on the test. I there a way for me to restart the test, in order to check whether it was just flaky?