fix type issue with VirtualPCIPassthrough #1318
Conversation
Received an error when trying to set up SRIOV: `AttributeError: type object 'vim.vm.device.VirtualPCIPassthrough' has no attribute 'DeviceBacking'` According to the docs as well, there is no attribute on VirtualPCIPassthrough named DeviceBacking https://vdc-repo.vmware.com/vmwb-repository/dcr-public/3325c370-b58c-4799-99ff-58ae3baac1bd/45789cc5-aba1-48bc-a320-5e35142b50af/doc/vim.vm.device.VirtualDevice.html#backing I believe the intent was to compare the nic backing to the VirtualPCIPassthrough device itself. After making this change, the module seems to work correctly for me
There was a problem hiding this comment.
Thanks for this PR @ckhordiasma!
Could you please add a changelog fragment like this? Something like:
bugfixes:
- vmware_guest_network - Fix an bug when configuring SR-IOV NICs (https://github.com/ansible-collections/community.vmware/pull/1318).
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
This change depends on a change that failed to merge. |
|
recheck |
|
This change depends on a change that failed to merge. |
|
This change depends on a change that failed to merge. |
|
recheck |
|
recheck |
|
recheck |
|
This change depends on a change that failed to merge. |
|
Greeeeeeeeeeeeeeeeen 🥳 💚 |
|
Thank you for your patience :-). |
No problem, you're welcome. Thanks for fixing the CI 👍 |
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 4m 08s |
Depends-On: ansible/ansible-zuul-jobs#1580
Depends-On: ansible/ansible-zuul-jobs#1582
SUMMARY
Received an error when trying to set up SRIOV:
AttributeError: type object 'vim.vm.device.VirtualPCIPassthrough' has no attribute 'DeviceBacking'According to the docs as well, there is no attribute on VirtualPCIPassthrough named DeviceBacking https://vdc-repo.vmware.com/vmwb-repository/dcr-public/3325c370-b58c-4799-99ff-58ae3baac1bd/45789cc5-aba1-48bc-a320-5e35142b50af/doc/vim.vm.device.VirtualDevice.html#backing
I believe the intent was to compare the nic backing to the VirtualPCIPassthrough device itself. After making this change, the module seems to work correctly for me
ISSUE TYPE
COMPONENT NAME
plugins/modules/vmware_guest_network.py
ADDITIONAL INFORMATION