Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate groups argument #295

Merged
merged 2 commits into from
Jun 20, 2022
Merged

deprecate groups argument #295

merged 2 commits into from
Jun 20, 2022

Conversation

hunleyd
Copy link
Collaborator

@hunleyd hunleyd commented Jun 18, 2022 •
edited
Loading

SUMMARY

Deprecate the groups arugment for eventual removal. End users should
use postgresql_membership instead to alter which groups/roles a db
user belongs to.

Spawned from #277

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

postgresql_user

@hunleyd
fix: deprecate groups argument
da5272b 
Deprecate the `groups` arugment for eventual removal. End users should
use `postgresql_membership` instead to alter which groups/roles a db
user belongs to.

Spawned from #277

Signed-off-by: Douglas J Hunley <doug.hunley@gmail.com>
@hunleyd hunleyd self-assigned this Jun 18, 2022
Andersson007
Andersson007 reviewed Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hunleyd thanks for the PR!

plugins/modules/postgresql_user.py Outdated Show resolved Hide resolved
@hunleyd @Andersson007
add actual deprecation makrup on the option
a6f1b47 
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
@hunleyd hunleyd requested a review from Andersson007 June 20, 2022 12:22
Andersson007
Andersson007 approved these changes Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hunleyd hunleyd merged commit fd11383 into ansible-collections:main Jun 20, 2022
@hunleyd hunleyd deleted the no_privs branch June 20, 2022 13:52
@patchback
Copy link

patchback bot commented Jun 22, 2022 •
edited
Loading

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/fd11383f44bf50c68d82f7d809c309248be95c9c/pr-295

Backported as #298

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 22, 2022
@hunleyd @patchback
deprecate groups argument (#295)
88c3d40 
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit fd11383)
@patchback patchback bot mentioned this pull request Jun 22, 2022
Merged
hunleyd added a commit that referenced this pull request Jun 22, 2022
@patchback @Andersson007 @hunleyd
[PR #295/fd11383f backport][stable-1] deprecate groups argument (#298)
1cbe469 
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Douglas J Hunley <doug.hunley@gmail.com>
@Andersson007 Andersson007 mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

@jchancojr jchancojr Awaiting requested review from jchancojr

Assignees

@hunleyd hunleyd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hunleyd @Andersson007