Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitwarden_secrets_manager: implement rate limit retry with backoff #8238

Merged
merged 5 commits into from
Apr 21, 2024

Conversation

mintyhippoxyz
Copy link
Contributor

SUMMARY

Fixes #8230

ISSUE TYPE
  • Bugfix Pull Request
  • Refactoring Pull Request
COMPONENT NAME

bitwarden_secrets_manager

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug lookup lookup plugin new_contributor Help guide this first time contributor plugins plugin (any type) labels Apr 19, 2024
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 backport-8 Automatically create a backport for the stable-8 branch labels Apr 19, 2024
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this before the next release on Monday.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 21, 2024
@felixfontein felixfontein merged commit a05a598 into ansible-collections:main Apr 21, 2024
132 of 133 checks passed
Copy link

patchback bot commented Apr 21, 2024

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/a05a5982a66e1c2cc37046ef97c637c782d1fcdd/pr-8238

Backported as #8260

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@mintyhippoxyz thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Apr 21, 2024
…8238)

* bitwarden_secrets_manager: implement rate limit retry with backoff (#8230)

* bitwarden_secrets_manager: add changelog fragment for 90cd2d6 (#8238)

* bitwarden_secrets_manager: clarify "Too many requests" is an error condition (#8238)

* bitwarden_secrets_manager: avoid an extra _run_with_retry execution after the last (very long) delay

* bitwarden_secrets_manager: changelog fragment key and reference issue url

(cherry picked from commit a05a598)
Copy link

patchback bot commented Apr 21, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/a05a5982a66e1c2cc37046ef97c637c782d1fcdd/pr-8238

Backported as #8261

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 21, 2024
…8238)

* bitwarden_secrets_manager: implement rate limit retry with backoff (#8230)

* bitwarden_secrets_manager: add changelog fragment for 90cd2d6 (#8238)

* bitwarden_secrets_manager: clarify "Too many requests" is an error condition (#8238)

* bitwarden_secrets_manager: avoid an extra _run_with_retry execution after the last (very long) delay

* bitwarden_secrets_manager: changelog fragment key and reference issue url

(cherry picked from commit a05a598)
felixfontein added a commit that referenced this pull request Apr 21, 2024
…lement rate limit retry with backoff (#8260)

* bitwarden_secrets_manager: implement rate limit retry with backoff (#8238)

* bitwarden_secrets_manager: implement rate limit retry with backoff (#8230)

* bitwarden_secrets_manager: add changelog fragment for 90cd2d6 (#8238)

* bitwarden_secrets_manager: clarify "Too many requests" is an error condition (#8238)

* bitwarden_secrets_manager: avoid an extra _run_with_retry execution after the last (very long) delay

* bitwarden_secrets_manager: changelog fragment key and reference issue url

(cherry picked from commit a05a598)

* Make Python 2 compatible.

---------

Co-authored-by: Matt Adams <matt@4dk.me>
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein pushed a commit that referenced this pull request Apr 21, 2024
…lement rate limit retry with backoff (#8261)

bitwarden_secrets_manager: implement rate limit retry with backoff (#8238)

* bitwarden_secrets_manager: implement rate limit retry with backoff (#8230)

* bitwarden_secrets_manager: add changelog fragment for 90cd2d6 (#8238)

* bitwarden_secrets_manager: clarify "Too many requests" is an error condition (#8238)

* bitwarden_secrets_manager: avoid an extra _run_with_retry execution after the last (very long) delay

* bitwarden_secrets_manager: changelog fragment key and reference issue url

(cherry picked from commit a05a598)

Co-authored-by: Matt Adams <matt@4dk.me>
aretrosen pushed a commit to aretrosen/community.general that referenced this pull request Apr 22, 2024
…nsible-collections#8238)

* bitwarden_secrets_manager: implement rate limit retry with backoff (ansible-collections#8230)

* bitwarden_secrets_manager: add changelog fragment for 90cd2d6 (ansible-collections#8238)

* bitwarden_secrets_manager: clarify "Too many requests" is an error condition (ansible-collections#8238)

* bitwarden_secrets_manager: avoid an extra _run_with_retry execution after the last (very long) delay

* bitwarden_secrets_manager: changelog fragment key and reference issue url
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
…nsible-collections#8238)

* bitwarden_secrets_manager: implement rate limit retry with backoff (ansible-collections#8230)

* bitwarden_secrets_manager: add changelog fragment for 90cd2d6 (ansible-collections#8238)

* bitwarden_secrets_manager: clarify "Too many requests" is an error condition (ansible-collections#8238)

* bitwarden_secrets_manager: avoid an extra _run_with_retry execution after the last (very long) delay

* bitwarden_secrets_manager: changelog fragment key and reference issue url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug lookup lookup plugin new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bitwarden_secrets_manager: Handle rate limits
3 participants