cargo: use the correct path when checking installation status fixing idempotency issue. #7970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog fragment? Thanks!
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Felix Fontein <felix@fontein.de>
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #8018 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
…idempotency issue. (#7970) * cargo: use the correct path when checking installation status * Add changelog fragment * Update changelogs/fragments/7970-fix-cargo-path-idempotency.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 9510988)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #8019 🤖 @patchback |
|
@rbomze thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
…idempotency issue. (#7970) * cargo: use the correct path when checking installation status * Add changelog fragment * Update changelogs/fragments/7970-fix-cargo-path-idempotency.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 9510988)
felixfontein
pushed a commit
that referenced
this pull request
Feb 23, 2024
…en checking installation status fixing idempotency issue. (#8018) cargo: use the correct path when checking installation status fixing idempotency issue. (#7970) * cargo: use the correct path when checking installation status * Add changelog fragment * Update changelogs/fragments/7970-fix-cargo-path-idempotency.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 9510988) Co-authored-by: rbomze <14312790+rbomze@users.noreply.github.com>
felixfontein
pushed a commit
that referenced
this pull request
Feb 23, 2024
…en checking installation status fixing idempotency issue. (#8019) cargo: use the correct path when checking installation status fixing idempotency issue. (#7970) * cargo: use the correct path when checking installation status * Add changelog fragment * Update changelogs/fragments/7970-fix-cargo-path-idempotency.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 9510988) Co-authored-by: rbomze <14312790+rbomze@users.noreply.github.com>
Although it were just 3 lines of code it was an honor to contribute to this great project. |
Closed
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
…idempotency issue. (ansible-collections#7970) * cargo: use the correct path when checking installation status * Add changelog fragment * Update changelogs/fragments/7970-fix-cargo-path-idempotency.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There is a problem when using the optional 'path' parameter. The initial installation works fine, but when running the module again the get_installed function, which is supposed to check the installation state does not use the parameter, thus a new installation is attempted, this again is registered by cargo install itself, but leads to a false 'changed' status, breaking ansibles' idempotency.
A similar problem occurs when removing packages.
This fix makes the get_installed function aware of the optional 'path' parameter.
ISSUE TYPE
COMPONENT NAME
cargo