Fixed payload format

[eeferg]

SUMMARY

Changes the REST API Payload format to work with the current status.io API

There was no known bugfix issue for this. I discovered it this week and found a fix.

bugfixes:

• community.general.statusio_maintenance - fix error caused by incorrectly formed api data payload. was raising Failed to create maintenance: HTTP Error 400: Bad Request caused by bad data type for date/time and deprecated dict keys.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

community.general.statusio_maintenance

ADDITIONAL INFORMATION

• API dates and times are expecting string but original module provided list type. Author added a step to turn the list of strings into a list of list items, containing one string each. I removed that step and correctly parse the strings into the payload.

The current status.io API requires a combined infrastructure ID, in the form of 'component_id-container_id'. I have not been able to find any change history on the API to show when this changed from what the original module was sending but the individual component_id and container_id are no longer supported.

$ ansible-playbook -i hosts.txt status-io-maintenance.yml

PLAY [Status.IO maintenance update] **************************************************************************************************************

TASK [Create a maintenance window for 60 minutes on server1 and server2] *************************************************************************
fatal: [localhost]: FAILED! => {"ansible_facts": {"discovered_interpreter_python": "/usr/bin/python3"}, "changed": false, "msg": "Failed to create maintenance: HTTP Error 400: Bad Request"}

PLAY RECAP ***************************************************************************************************************************************
localhost                  : ok=0    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0   


$ ansible-playbook -i hosts.txt status-io-maintenance.yml

PLAY [Status.IO maintenance update] **************************************************************************************************************

TASK [Create a maintenance window for 60 minutes on server1 and server2] *************************************************************************
changed: [localhost]

PLAY RECAP ***************************************************************************************************************************************
localhost                  : ok=1    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0 

[ansibullbot]

cc @bhcopeland
click here for bot help

[felixfontein]

Thanks for your contribution. Could you please add a changelog fragment? Thanks.

[eeferg]

I have added the changelog fragment.

[bhcopeland]

LGTM! Thanks for the contribution!

[felixfontein]

@eeferg in case you added the changelog fragment, you haven't pushed it :)

[felixfontein]

(It's a YAML file in changelogs/fragments/.)

[eeferg]

Thanks for the assistance on my first commit.

[patchback]

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/4a1006ac34460b0819007c13d0aab191cb607673/pr-7754

Backported as #7762

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/4a1006ac34460b0819007c13d0aab191cb607673/pr-7754

Backported as #7763

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@eeferg thank you very much for fixing this!
@bhcopeland thanks a lot for reviewing!