Fix Keycloak API client to quote '/' properly #7641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelogs/fragments/7641-fix-keycloak-api-client-to-quote-properly.yml
Outdated
Show resolved
Hide resolved
…perly.yml Co-authored-by: Felix Fontein <felix@fontein.de>
|
recheck |
|
If nobody objects, I'll merge this on the upcoming weekend! |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7664 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 2, 2023
* fix Keycloak API client to quote '/' properly * add changelog * Update changelogs/fragments/7641-fix-keycloak-api-client-to-quote-properly.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 58cce27)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #7665 🤖 @patchback |
|
@kota65535 thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Dec 2, 2023
* fix Keycloak API client to quote '/' properly * add changelog * Update changelogs/fragments/7641-fix-keycloak-api-client-to-quote-properly.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 58cce27)
felixfontein
pushed a commit
that referenced
this pull request
Dec 2, 2023
…te '/' properly (#7664) Fix Keycloak API client to quote '/' properly (#7641) * fix Keycloak API client to quote '/' properly * add changelog * Update changelogs/fragments/7641-fix-keycloak-api-client-to-quote-properly.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 58cce27) Co-authored-by: Tomohiko Ozawa <kota65535@gmail.com>
felixfontein
pushed a commit
that referenced
this pull request
Dec 2, 2023
…te '/' properly (#7665) Fix Keycloak API client to quote '/' properly (#7641) * fix Keycloak API client to quote '/' properly * add changelog * Update changelogs/fragments/7641-fix-keycloak-api-client-to-quote-properly.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 58cce27) Co-authored-by: Tomohiko Ozawa <kota65535@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fix: #6515
Currently, Keycloak API client uses urllib.parse.quote when building URLs with path parameters, but it does not handle '/' (slash) by default. This PR makes it handle properly.
ISSUE TYPE
COMPONENT NAME
keycloak_*