Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redhat_subscription: use D-Bus registration on RHEL 7 only on 7.4+ #7624

Merged
merged 1 commit into from
Nov 30, 2023
Merged

redhat_subscription: use D-Bus registration on RHEL 7 only on 7.4+ #7624

merged 1 commit into from
Nov 30, 2023

Conversation

ptoscano
Copy link
Contributor

SUMMARY

subscription-manager does not provide a D-Bus interface in versions of RHEL 7 older than 7.4.

Fixes #7622

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

redhat_subscription

@ptoscano ptoscano mentioned this pull request Nov 28, 2023
Closed
@ansibullbot
Copy link
Collaborator

cc @cnsnyder
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) redhat_subscription tests tests unit tests/unit labels Nov 28, 2023
@ptoscano
redhat_subscription: use D-Bus registration on RHEL 7 only on 7.4+
6c5f907 
subscription-manager does not provide a D-Bus interface in versions of
RHEL 7 older than 7.4.
@ptoscano ptoscano force-pushed the redhat_subscription-dbus-on-7.4-plus branch from 2d029dd to 6c5f907 Compare November 28, 2023 11:11
@ptoscano ptoscano mentioned this pull request Nov 28, 2023
Closed
1 task
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 backport-8 Automatically create a backport for the stable-8 branch labels Nov 28, 2023
@ptoscano
Copy link
Contributor Author

/rebuild_failed

@felixfontein
Copy link
Collaborator

recheck

@felixfontein
Copy link
Collaborator

(Zuul uses something else, of coure ;) But you don't need to worry about that one failing, it does it from time to time, and I usually ignore it anyway...)

@ptoscano
Copy link
Contributor Author

Hey @johanburati,

since you reported #7622: would it be possible for you to test this in your environment? Thanks!

@johanburati
Copy link

johanburati commented Nov 30, 2023 •
edited
Loading

Awesome @ptoscano ! I 've tested it and I confirm it is working now ! Thanks a lot ! 🎉

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 30, 2023
@felixfontein felixfontein merged commit af01b46 into ansible-collections:main Nov 30, 2023
@patchback Patchback
Copy link

patchback bot commented Nov 30, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/af01b462d5681c9c8216ab43b2be71648db3ae29/pr-7624

Backported as #7642

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 30, 2023
@ptoscano @patchback
redhat_subscription: use D-Bus registration on RHEL 7 only on 7.4+ (#…
532e408 
…7624)

subscription-manager does not provide a D-Bus interface in versions of
RHEL 7 older than 7.4.

(cherry picked from commit af01b46)
@patchback patchback bot mentioned this pull request Nov 30, 2023
Merged
@patchback Patchback
Copy link

patchback bot commented Nov 30, 2023 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/af01b462d5681c9c8216ab43b2be71648db3ae29/pr-7624

Backported as #7643

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@ptoscano thanks for fixing this!
@johanburati thanks for testing this!

patchback bot pushed a commit that referenced this pull request Nov 30, 2023
@ptoscano @patchback
redhat_subscription: use D-Bus registration on RHEL 7 only on 7.4+ (#…
8c3643a 
…7624)

subscription-manager does not provide a D-Bus interface in versions of
RHEL 7 older than 7.4.

(cherry picked from commit af01b46)
@patchback patchback bot mentioned this pull request Nov 30, 2023
Merged
felixfontein pushed a commit that referenced this pull request Nov 30, 2023
@patchback @ptoscano
[PR #7624/af01b462 backport][stable-7] redhat_subscription: use D-Bus…
3593d9c 
… registration on RHEL 7 only on 7.4+ (#7642)

redhat_subscription: use D-Bus registration on RHEL 7 only on 7.4+ (#7624)

subscription-manager does not provide a D-Bus interface in versions of
RHEL 7 older than 7.4.

(cherry picked from commit af01b46)

Co-authored-by: Pino Toscano <ptoscano@redhat.com>
felixfontein pushed a commit that referenced this pull request Nov 30, 2023
@patchback @ptoscano
[PR #7624/af01b462 backport][stable-8] redhat_subscription: use D-Bus…
d87b91e 
… registration on RHEL 7 only on 7.4+ (#7643)

redhat_subscription: use D-Bus registration on RHEL 7 only on 7.4+ (#7624)

subscription-manager does not provide a D-Bus interface in versions of
RHEL 7 older than 7.4.

(cherry picked from commit af01b46)

Co-authored-by: Pino Toscano <ptoscano@redhat.com>
@ptoscano ptoscano deleted the redhat_subscription-dbus-on-7.4-plus branch November 30, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug has_issue module module plugins plugin (any type) redhat_subscription tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redhat_subscription module fails on RHEL 7.3
4 participants
@ptoscano @ansibullbot @felixfontein @johanburati