Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onepassword lookup - Make section and field case insensitive #7564

Merged
merged 4 commits into from
Dec 1, 2023
Merged

onepassword lookup - Make section and field case insensitive #7564

merged 4 commits into from
Dec 1, 2023

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Nov 21, 2023 •
edited
Loading

SUMMARY

This was a regression in behavior when adding support for op v2.

Fixes #6000

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/lookup/onepassword.py

@samdoran samdoran changed the title onepassword lookup Make section and field case insensitive onepassword lookup - Make section and field case insensitive Nov 21, 2023
@samdoran samdoran marked this pull request as ready for review November 21, 2023 15:34
@ansibullbot
Copy link
Collaborator

cc @azenk
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug lookup lookup plugin plugins plugin (any type) tests tests unit tests/unit labels Nov 21, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 backport-8 Automatically create a backport for the stable-8 branch labels Nov 22, 2023
@samdoran samdoran force-pushed the issue/6000-opv2-case-insensitive branch from d1cbd1a to 155846e Compare November 26, 2023 18:41
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 26, 2023
@samdoran samdoran force-pushed the issue/6000-opv2-case-insensitive branch from 3176a35 to 3b233e0 Compare November 26, 2023 21:41
@samdoran samdoran force-pushed the issue/6000-opv2-case-insensitive branch from 3b233e0 to 2caa65a Compare November 26, 2023 21:43
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 26, 2023
@felixfontein
Copy link
Collaborator

Looks good to me! I'll merge this in a couple of days if nobody objects.

@samdoran samdoran mentioned this pull request Nov 27, 2023
Closed
1 task
@felixfontein
Copy link
Collaborator

@samdoran do you want to wait a bit longer for feedback, or should I merge now?

@samdoran
Copy link
Contributor Author

samdoran commented Dec 1, 2023

@felixfontein Merge away!

@felixfontein felixfontein merged commit 241cc02 into ansible-collections:main Dec 1, 2023
@patchback Patchback
Copy link

patchback bot commented Dec 1, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/241cc02fa8e2581faad8aec946883be4c28954f2/pr-7564

Backported as #7661

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 1, 2023
patchback bot pushed a commit that referenced this pull request Dec 1, 2023
@samdoran @patchback
onepassword lookup - Make section and field case insensitive (#7564)
851405e 
* onepassword lookup: Make section and field case insensitive

This was a regression in behavior when adding support for op v2.

* Return a string by default to avoid an exception if a field is missing

* Use a helper function to lower a value if possible

* Update changelog

(cherry picked from commit 241cc02)
@patchback patchback bot mentioned this pull request Dec 1, 2023
Merged
@patchback Patchback
Copy link

patchback bot commented Dec 1, 2023 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/241cc02fa8e2581faad8aec946883be4c28954f2/pr-7564

Backported as #7662

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@samdoran done :) Thanks a lot for fixing this!

patchback bot pushed a commit that referenced this pull request Dec 1, 2023
@samdoran @patchback
onepassword lookup - Make section and field case insensitive (#7564)
d57878e 
* onepassword lookup: Make section and field case insensitive

This was a regression in behavior when adding support for op v2.

* Return a string by default to avoid an exception if a field is missing

* Use a helper function to lower a value if possible

* Update changelog

(cherry picked from commit 241cc02)
@patchback patchback bot mentioned this pull request Dec 1, 2023
Merged
felixfontein pushed a commit that referenced this pull request Dec 1, 2023
@patchback @samdoran
[PR #7564/241cc02f backport][stable-7] onepassword lookup - Make sect…
84c883e 
…ion and field case insensitive (#7661)

onepassword lookup - Make section and field case insensitive (#7564)

* onepassword lookup: Make section and field case insensitive

This was a regression in behavior when adding support for op v2.

* Return a string by default to avoid an exception if a field is missing

* Use a helper function to lower a value if possible

* Update changelog

(cherry picked from commit 241cc02)

Co-authored-by: Sam Doran <sdoran@redhat.com>
felixfontein pushed a commit that referenced this pull request Dec 1, 2023
@patchback @samdoran
[PR #7564/241cc02f backport][stable-8] onepassword lookup - Make sect…
fc02a7c 
…ion and field case insensitive (#7662)

onepassword lookup - Make section and field case insensitive (#7564)

* onepassword lookup: Make section and field case insensitive

This was a regression in behavior when adding support for op v2.

* Return a string by default to avoid an exception if a field is missing

* Use a helper function to lower a value if possible

* Update changelog

(cherry picked from commit 241cc02)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@samdoran samdoran mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug has_issue lookup lookup plugin plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Onepassword v2 Lookup Plugin is Case Sensitive
3 participants
@samdoran @ansibullbot @felixfontein