Lxd instance not found fix false positives

[tim-seoss]

SUMMARY

lxd: avoid false positives in "instance not found" detection in the lxd connection plugin

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lxd connection plugin

ADDITIONAL INFORMATION

before:

fatal: [my-rpi-399]: UNREACHABLE! => {
    "changed": false,
    "msg": "instance not found: my-rpi-399",
    "unreachable": true
}

after:

fatal: [my-rpi-399]: FAILED! => {
    "ansible_facts": {},
    "changed": false,
    "failed_modules": {
        "ansible.legacy.setup": {
            "failed": true,
            "module_stderr": "/bin/sh: 1: /usr/bin/python3: not found\nError: Command not found\n",
            "module_stdout": "",
            "msg": "The module failed to execute correctly, you probably need to set the interpreter.\nSee stdout/stderr for the exact error",
            "rc": 127
        }
    },
    "msg": "The following modules failed to execute: ansible.legacy.setup\n"
}

[ansibullbot]

cc @mattclay
click here for bot help

[felixfontein]

Thanks for your contribution!

[felixfontein]

If nobody objects, I'll merge this in a few days.

[patchback]

Backport to stable-7: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply b4a2e9d on top of patchback/backports/stable-7/b4a2e9da50d7483c985e8fc2bcfb12db75b437c4/pr-7521

Backporting merged PR #7521 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible-collections/community.general.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-7/b4a2e9da50d7483c985e8fc2bcfb12db75b437c4/pr-7521 upstream/stable-7

4. Now, cherry-pick PR Lxd instance not found fix false positives #7521 contents into that branch:

   $ git cherry-pick -x b4a2e9da50d7483c985e8fc2bcfb12db75b437c4

   If it'll yell at you with something like fatal: Commit b4a2e9da50d7483c985e8fc2bcfb12db75b437c4 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x b4a2e9da50d7483c985e8fc2bcfb12db75b437c4

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Lxd instance not found fix false positives #7521 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-7/b4a2e9da50d7483c985e8fc2bcfb12db75b437c4/pr-7521

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/b4a2e9da50d7483c985e8fc2bcfb12db75b437c4/pr-7521

Backported as #7671

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@tim-seoss thanks for your contribution!