Fix callback/selective task print being long #7374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare against all text on the line rather than simply the task_name var, which does not include 3 formatting characters in the string
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi @AidanHouck , Thank you for the contribution! Please add a changelog fragment. |
russoz
reviewed
Oct 9, 2023
|
/rebuild |
russoz
reviewed
Oct 10, 2023
changelogs/fragments/7374-fix-selective-callback-taskname-length.yml
Outdated
Show resolved
Hide resolved
5c6813f to
132029e
Compare
132029e to
a618f7d
Compare
|
CI failures are unrelated and should get fixed by #7385. |
|
/rebuild_failed |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #7390 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Fix callback/selective task print being long Compare against all text on the line rather than simply the task_name var, which does not include 3 formatting characters in the string * Add changelog fragment --------- Co-authored-by: Aidan Houck <AidanHouck@users.noreply.github.com> (cherry picked from commit 479e7df)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7391 🤖 @patchback |
|
@AidanHouck thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Fix callback/selective task print being long Compare against all text on the line rather than simply the task_name var, which does not include 3 formatting characters in the string * Add changelog fragment --------- Co-authored-by: Aidan Houck <AidanHouck@users.noreply.github.com> (cherry picked from commit 479e7df)
felixfontein
pushed a commit
that referenced
this pull request
Oct 11, 2023
…int being long (#7390) Fix callback/selective task print being long (#7374) * Fix callback/selective task print being long Compare against all text on the line rather than simply the task_name var, which does not include 3 formatting characters in the string * Add changelog fragment --------- Co-authored-by: Aidan Houck <AidanHouck@users.noreply.github.com> (cherry picked from commit 479e7df) Co-authored-by: Aidan Houck <92699100+AidanHouck@users.noreply.github.com>
felixfontein
pushed a commit
that referenced
this pull request
Oct 11, 2023
…int being long (#7391) Fix callback/selective task print being long (#7374) * Fix callback/selective task print being long Compare against all text on the line rather than simply the task_name var, which does not include 3 formatting characters in the string * Add changelog fragment --------- Co-authored-by: Aidan Houck <AidanHouck@users.noreply.github.com> (cherry picked from commit 479e7df) Co-authored-by: Aidan Houck <92699100+AidanHouck@users.noreply.github.com>
etrombly
pushed a commit
to etrombly/community.general
that referenced
this pull request
Oct 25, 2023
* Fix callback/selective task print being long Compare against all text on the line rather than simply the task_name var, which does not include 3 formatting characters in the string * Add changelog fragment --------- Co-authored-by: Aidan Houck <AidanHouck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When printing the task name section of command output, previously the line was always 3 chars longer than
line_lengthwhich is meant to limit width. This was due to the length check simply looking at thetask_name, and not including the 3 formatting characters added in the string directly (# {0}).To fix this, I pulled these characters out into a separate variable then did the length check on that.
bugfixes:
ISSUE TYPE
COMPONENT NAME
selective
ADDITIONAL INFORMATION
Note that there are many other checks in this plugin that also do not properly follow the
line_lengthvariable for one reason or another. I will submit fixes for those later in a separate PR as they are not as trivial to resolve.