Adding deprecation for timeout parameter from 10 to 60 for redfish_info, redfish_config and redfish_command #7295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h_config and redfish_command
changelogs/fragments/7295-adding_deprecation_for_timeout_in_redfish_info_config_command.yml
Outdated
Show resolved
Hide resolved
changelogs/fragments/7295-adding_deprecation_for_timeout_in_redfish_info_config_command.yml
Outdated
Show resolved
Hide resolved
…dfish_info_config_command.yml Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de>
…dfish_info_config_command.yml Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de>
Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de>
Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
Sep 21, 2023
|
Looks good to me |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7327 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
…fo, redfish_config and redfish_command (#7295) * Adding deprecation for timeout from 10 to 60 for redfish_info, redfish_config and redfish_command * Adding changelog fragment and sanity fixes * Update changelogs/fragments/7295-adding_deprecation_for_timeout_in_redfish_info_config_command.yml Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/7295-adding_deprecation_for_timeout_in_redfish_info_config_command.yml Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/redfish_command.py Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/redfish_command.py Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Updating release version --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit eae7161)
felixfontein
pushed a commit
that referenced
this pull request
Sep 29, 2023
… parameter from 10 to 60 for redfish_info, redfish_config and redfish_command (#7327) Adding deprecation for timeout parameter from 10 to 60 for redfish_info, redfish_config and redfish_command (#7295) * Adding deprecation for timeout from 10 to 60 for redfish_info, redfish_config and redfish_command * Adding changelog fragment and sanity fixes * Update changelogs/fragments/7295-adding_deprecation_for_timeout_in_redfish_info_config_command.yml Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/7295-adding_deprecation_for_timeout_in_redfish_info_config_command.yml Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/redfish_command.py Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/redfish_command.py Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Updating release version --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit eae7161) Co-authored-by: TSKushal <44438079+TSKushal@users.noreply.github.com>
etrombly
pushed a commit
to etrombly/community.general
that referenced
this pull request
Oct 25, 2023
…fo, redfish_config and redfish_command (ansible-collections#7295) * Adding deprecation for timeout from 10 to 60 for redfish_info, redfish_config and redfish_command * Adding changelog fragment and sanity fixes * Update changelogs/fragments/7295-adding_deprecation_for_timeout_in_redfish_info_config_command.yml Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelogs/fragments/7295-adding_deprecation_for_timeout_in_redfish_info_config_command.yml Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/redfish_command.py Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/redfish_command.py Agreed. Thanks! Co-authored-by: Felix Fontein <felix@fontein.de> * Updating release version --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding deprecation notice for timeout parameter.
Old value was 10. Proposed new value is 60.
Suggesting an increase in the timeout since we observed delayed responses from Gen11 servers while testing.
ISSUE TYPE
COMPONENT NAME
redfish_info.py
redfish_config.py
redfish_command.py