Use get(..) instead of [..] for safe lookup of value (Fixes #7240)

[wkleinheerenbrink]

A OnePassword field item might not have a value (property) when the user has omitted it (on purpose).

SUMMARY

ISSUE TYPE

• Bugfix Pull Request (fixes OnePassword library assumes incorrectly that a field als an attribute 'value' #7240 )

COMPONENT NAME

OnePassword

ADDITIONAL INFORMATION

[ansibullbot]

cc @azenk @samdoran @scottsb
click here for bot help

[felixfontein]

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

[samdoran]

It would be good to add tests for this. There is already a test written, you just need to provide new fixture data.

A new file with the output from op item get [item name] --format json (minus any sensitive data) needs to go in tests/unit/plugins/lookup/onepassword_fixtures/v2_out_04.json.

A new entry in the test matrix needs to go here. It will look something like this:

{
    # Request data from a custom field with no value
    "vault_name": "Test Vault",
    "queries": ["Dummy Login"],
    "kwargs": {
        "field": "some-omitted-property",
    },
    "expected": [""],
    "output": load_file("v2_out_04.json")
},

You can run the test from the root of the collection by running ansible-test units --docker default tests/unit/plugins/lookup/test_onepassword.py --python 3.11.

That's a lot so please feel free to ask for help. Thanks for fixing this!

[samdoran]

Looks great!

shipit

[patchback]

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/1beb38ceff80b9e1d1437cab2ba27deff6a73124/pr-7241

Backported as #7257

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/1beb38ceff80b9e1d1437cab2ba27deff6a73124/pr-7241

Backported as #7258

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@wkleinheerenbrink thanks for your contribution!
@samdoran thanks for reviewing!