Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpanm: using yaml-specified unit tests #7231

Merged
merged 3 commits into from
Sep 10, 2023
Merged

cpanm: using yaml-specified unit tests #7231

merged 3 commits into from
Sep 10, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Sep 10, 2023 •
edited
Loading

SUMMARY

Use help tester to run YAML-specified testcases. We had to make some minor adjustments in the module's code as well.

ISSUE TYPE
  • Refactoring Pull Request
  • Test Pull Request
COMPONENT NAME

plugins/modules/cpanm.py
tests/unit/plugins/modules/test_cpanm.py
tests/unit/plugins/modules/test_cpanm.yaml

@ansibullbot
Copy link
Collaborator

cc @fcuny
click here for bot help

@ansibullbot ansibullbot added module module new_plugin New plugin plugins plugin (any type) tests tests unit tests/unit labels Sep 10, 2023
@felixfontein felixfontein added backport-6 check-before-release PR will be looked at again shortly before release and merged if possible. and removed backport-6 labels Sep 10, 2023
@felixfontein felixfontein merged commit 517e2d4 into ansible-collections:main Sep 10, 2023
@patchback
Copy link

patchback bot commented Sep 10, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/517e2d48ebb3008910176aa1f88b7b7558c9a477/pr-7231

Backported as #7233

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Sep 10, 2023
@patchback patchback bot mentioned this pull request Sep 10, 2023
Merged
patchback bot pushed a commit that referenced this pull request Sep 10, 2023
@russoz @patchback
cpanm: using yaml-specified unit tests (#7231)
a6bf3ba 
* cpanm: using yaml-specified unit tests

* add quote around URLs to appease pyaml@py26

* add changelog frag

(cherry picked from commit 517e2d4)
@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!

@russoz russoz deleted the cmd-yaml-tests-cpanm branch September 10, 2023 19:32
felixfontein pushed a commit that referenced this pull request Sep 10, 2023
@patchback @russoz
[PR #7231/517e2d48 backport][stable-7] cpanm: using yaml-specified un…
418589e 
…it tests (#7233)

cpanm: using yaml-specified unit tests (#7231)

* cpanm: using yaml-specified unit tests

* add quote around URLs to appease pyaml@py26

* add changelog frag

(cherry picked from commit 517e2d4)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
etrombly pushed a commit to etrombly/community.general that referenced this pull request Oct 25, 2023
@russoz
cpanm: using yaml-specified unit tests (ansible-collections#7231)
7417e92 
* cpanm: using yaml-specified unit tests

* add quote around URLs to appease pyaml@py26

* add changelog frag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module module new_plugin New plugin plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein