bitwarden lookup fix get_field

[simonLeary42]

SUMMARY

A bitwarden record without any custom fields will throw a KeyError when you try to search with field='notes'. The code here tries to open match['fields'] without first checking if the key fields exists in match.
It turns out that with the current logic you can't get the notes field. It's either the login fields or custom fields. The new logic looks for your key in custom fields, then in login fields, then in the general fields for that record.

Fixes #6617

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

bitwarden

ADDITIONAL INFORMATION

Here's the structure of a bitwarden record json object:

{
    "collectionIds": null,
    "creationDate": null,
    "deletedDate": null,
    "favorite": false,
    "fields": [
        {
            "linkedId": null,
            "name": "custom-field1",
            "type": null,
            "value": null
        }
        {
            "linkedId": null,
            "name": "custom-field2",
            "type": null,
            "value": null
        }
    ],
    "folderId": null,
    "id": null,
    "login": {
        "password": null,
        "passwordRevisionDate": null,
        "totp": null,
        "username": null
    },
    "name": null,
    "notes": null,
    "object": null,
    "organizationId": null,
    "passwordHistory": null,
    "reprompt": null,
    "revisionDate": null,
    "type": null,
}

BEFORE AND AFTER

- name: print bitwarden value
  debug:
    msg: "{{ lookup('community.general.bitwarden', 'record-name', field='notes') }}"

before:

TASK [hostname : print bitwarden value] ******************************************************************************
fatal: [hostname]: FAILED! => {"msg": "An unhandled exception occurred while running the lookup plugin 'community.general.bitwarden'. Error was a <class 'KeyError'>, original message: 'fields'. 'fields'"}

after:

ok: [hostname] => {
    "msg": [
        "these are notes"
    ]
}

[simonLeary42]

when a bitwarden record has no custom fields, fields is not an empty list, it doesn't exist at all.

{
    "collectionIds": null,
    "creationDate": null,
    "deletedDate": null,
    "favorite": false,
    "folderId": null,
    "id": null,
    "login": {
        "password": null,
        "passwordRevisionDate": null,
        "totp": null,
        "username": null
    },
    "name": null,
    "notes": null,
    "object": null,
    "organizationId": null,
    "passwordHistory": null,
    "reprompt": null,
    "revisionDate": null,
    "type": null,
}

[ansibullbot]

cc @lungj
click here for bot help

[felixfontein]

Thanks for your contribution!

[simonLeary42]

suggestions committed

[simonLeary42]

#6617

[felixfontein]

If nobody objects, I'll merge this in ~a week.

[patchback]

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/e75dc74613641ad278a4a1272289dad9179b9b49/pr-7061

Backported as #7089

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/e75dc74613641ad278a4a1272289dad9179b9b49/pr-7061

Backported as #7090

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@simonLeary42 thanks for your contribution!