-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redfish_utils: Add support for "nextLink" property tag pagination #7020
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Looks good to me! |
@sseekamp This PR contains |
Co-authored-by: Felix Fontein <felix@fontein.de>
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7026 🤖 @patchback |
) * Add support for Redfish "nextLink" property tag pagination for FirmwareInventory * Add changelog fragment * Fix indention * Updated fragment per suggestion Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit b46d5d8)
… "nextLink" property tag pagination (#7026) redfish_utils: Add support for "nextLink" property tag pagination (#7020) * Add support for Redfish "nextLink" property tag pagination for FirmwareInventory * Add changelog fragment * Fix indention * Updated fragment per suggestion Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit b46d5d8) Co-authored-by: Scott Seekamp <sseekamp@coreweave.com>
…fish_utils: Add support for "nextLink" property tag pagination (ansible-collections#7026)" This reverts commit 1dad953.
* Revert "[PR #7020/b46d5d81 backport][stable-7] redfish_utils: Add support for "nextLink" property tag pagination (#7026)" This reverts commit 1dad953. * Revert "[PR #6914/17b4219b backport][stable-7] proxmox_kvm: enable 'force' restart of vm (as documented) (#6997)" This reverts commit 7d68af5. * Revert "[PR #6976/d7c1a814 backport][stable-7] [proxmox_vm_info] Re-use cluster resources API to use module without requiring node param (#6993)" This reverts commit fb3768a.
SUMMARY
Add support for paginated responses in the _software_inventory method
Fixes #7011
ISSUE TYPE
COMPONENT NAME
redfish_utils
ADDITIONAL INFORMATION
Redfish supports a property in responses
@odata.nextLink
which indicates a partial set of data is returned (paginated response). The existing method would truncate the returned data with no indication items were missing from the response.Running a normal firmware inventory task:
Would return:
which corresponded with the first page of response from a raw curl request:
After the change:
which is the expected full collection of firmware inventory items.