Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grimoire management to sorcery module #7012

Merged
merged 9 commits into from
Aug 9, 2023

Conversation

vaygr
Copy link
Contributor

@vaygr vaygr commented Jul 25, 2023

SUMMARY

community.general.sorcery: add support for grimoire management.
In SMGL glossary it's repository management, similar to apt.

Official and personal repository usage is described here and here.

The PR also contains a couple of minor fixes and documentation corrections to the module.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

community.general.sorcery

ADDITIONAL INFORMATION

N/A

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels Jul 25, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 labels Jul 26, 2023
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Jul 27, 2023
Co-authored-by: Felix Fontein <felix@fontein.de>
@vaygr vaygr force-pushed the sorcery-grimoire-mgmt branch from 6b24ffb to 18f9bb4 Compare July 27, 2023 14:33
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jul 27, 2023
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this by the end of this week.

vaygr and others added 2 commits August 7, 2023 13:13
@felixfontein
Copy link
Collaborator

Are you planning to add more changes?

@vaygr
Copy link
Contributor Author

vaygr commented Aug 8, 2023

@felixfontein no, this is ready to go.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Aug 9, 2023
@felixfontein felixfontein merged commit d744255 into ansible-collections:main Aug 9, 2023
@patchback
Copy link

patchback bot commented Aug 9, 2023

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/d74425580bc51f5d51edcd07bff060978377514f/pr-7012

Backported as #7078

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 9, 2023
* Add grimoire management to sorcery module

* Add changelog fragment

* Bump copyright year

* Separate update_cache and latest state

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add note on latest state and cache_update link

* Unblock execution of multiple stages

* Update plugins/modules/sorcery.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update Codex logic to match Sorcery

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit d744255)
@felixfontein
Copy link
Collaborator

@vaygr thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Aug 9, 2023
…cery module (#7078)

Add grimoire management to sorcery module (#7012)

* Add grimoire management to sorcery module

* Add changelog fragment

* Bump copyright year

* Separate update_cache and latest state

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add note on latest state and cache_update link

* Unblock execution of multiple stages

* Update plugins/modules/sorcery.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update Codex logic to match Sorcery

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit d744255)

Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com>
@vaygr vaygr deleted the sorcery-grimoire-mgmt branch August 9, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants