Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keycloak client secret #6931

Merged
merged 8 commits into from
Aug 8, 2023
Merged

Keycloak client secret #6931

merged 8 commits into from
Aug 8, 2023

Conversation

desand01
Copy link
Contributor

SUMMARY

Fixe new client created without secret when "protocol" is omited and publicClient is False
Keycloak version 18.0.2

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak_client.py

ADDITIONAL INFORMATION
- name: Create Keycloak confidential client 
  community.general.keycloak_client:
    auth_keycloak_url: https://auth.example.com/auth
    auth_realm: master
    auth_username: USENAME
    auth_password: PASSWORD
    client_id: test
    publicClient: False
    state: present

@ansibullbot
Copy link
Collaborator

@desand01 this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug merge_commit This PR contains at least one merge commit. Please resolve! module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html new_contributor Help guide this first time contributor labels Jul 14, 2023
felixfontein
felixfontein reviewed Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I don't know the keycloak modules well, but I still have a general comment below.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 labels Jul 14, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 17, 2023
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jul 17, 2023
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jul 27, 2023
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Aug 3, 2023
@desand01 @felixfontein
Update plugins/modules/keycloak_client.py
b22d8ad 
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein
Copy link
Collaborator

If nobody objects, I'll merge this at the beginning of next week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Aug 8, 2023
@felixfontein felixfontein merged commit 91152cb into ansible-collections:main Aug 8, 2023
@patchback
Copy link

patchback bot commented Aug 8, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/91152cb123661f12bd8a24270e03b076a242ab7c/pr-6931

Backported as #7077

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@desand01 thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Aug 8, 2023
@desand01 @patchback
Keycloak client secret (#6931)
05240ec 
* fixe missing secret at creation

* Update doc

* changelogs

* Default protocol only when creation

* Fix sanity test

* Add documentation

* Update plugins/modules/keycloak_client.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Andre Desrosiers <andre.desrosiers@ssss.gouv.qc.ca>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 91152cb)
@patchback patchback bot mentioned this pull request Aug 8, 2023
Merged
felixfontein pushed a commit that referenced this pull request Aug 9, 2023
@patchback @desand01
[PR #6931/91152cb1 backport][stable-7] Keycloak client secret (#7077)
fb5047b 
Keycloak client secret (#6931)

* fixe missing secret at creation

* Update doc

* changelogs

* Default protocol only when creation

* Fix sanity test

* Add documentation

* Update plugins/modules/keycloak_client.py

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Andre Desrosiers <andre.desrosiers@ssss.gouv.qc.ca>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 91152cb)

Co-authored-by: desand01 <desrosiers.a@hotmail.com>
@desand01 desand01 deleted the keycloak_client_secret branch August 9, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug merge_commit This PR contains at least one merge commit. Please resolve! module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html new_contributor Help guide this first time contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desand01 @ansibullbot @felixfontein