Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key error for reverse zone (#6905) #6906

Merged
merged 3 commits into from
Jul 16, 2023
Merged

Fix key error for reverse zone (#6905) #6906

merged 3 commits into from
Jul 16, 2023

Conversation

irozet12
Copy link
Contributor

SUMMARY

Checking if 'idnsallowsyncptr' key exists in Freeipa response, before using this key

Fixes #6905

bugfixes:

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ipa_dnszone

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @Akasurde @Nosmoht @fxfitz @justchris1
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Jul 10, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jul 12, 2023
felixfontein
felixfontein reviewed Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

@felixfontein
Copy link
Collaborator

recheck

@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Jul 13, 2023
@irozet12
Copy link
Contributor Author

Thanks for your contribution! Can you please add a changelog fragment? Thanks.

Added. Thanks

@irozet12 @felixfontein
Fix changelog (6905)
2c03a6f 
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
felixfontein approved these changes Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell it looks good. I'll merge tomorrow if nobody objects.

@felixfontein felixfontein merged commit b818afd into ansible-collections:main Jul 16, 2023
@patchback
Copy link

patchback bot commented Jul 16, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/b818afd46426cacbec6191a0f2a28927139aad19/pr-6906

Backported as #6950

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 16, 2023
@irozet12 @patchback
Fix key error for reverse zone (#6905) (#6906)
e18432f 
* Fix key error for reverse zone (#6905)

* Add changelog fragment for #6905

* Fix changelog (6905)

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b818afd)
@patchback patchback bot mentioned this pull request Jul 16, 2023
Merged
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 16, 2023
@patchback
Copy link

patchback bot commented Jul 16, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/b818afd46426cacbec6191a0f2a28927139aad19/pr-6906

Backported as #6951

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 16, 2023
@irozet12 @patchback
Fix key error for reverse zone (#6905) (#6906)
56fc6d9 
* Fix key error for reverse zone (#6905)

* Add changelog fragment for #6905

* Fix changelog (6905)

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b818afd)
@patchback patchback bot mentioned this pull request Jul 16, 2023
Merged
@felixfontein
Copy link
Collaborator

@irozet12 thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Jul 16, 2023
@patchback @irozet12
[PR #6906/b818afd4 backport][stable-6] Fix key error for reverse zone (…
15c832b 
…#6905) (#6950)

Fix key error for reverse zone (#6905) (#6906)

* Fix key error for reverse zone (#6905)

* Add changelog fragment for #6905

* Fix changelog (6905)

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b818afd)

Co-authored-by: irozet12 <119814380+irozet12@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Jul 16, 2023
@patchback @irozet12
[PR #6906/b818afd4 backport][stable-7] Fix key error for reverse zone (…
a1582aa 
…#6905) (#6951)

Fix key error for reverse zone (#6905) (#6906)

* Fix key error for reverse zone (#6905)

* Add changelog fragment for #6905

* Fix changelog (6905)

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b818afd)

Co-authored-by: irozet12 <119814380+irozet12@users.noreply.github.com>
valeriopoggi pushed a commit to valeriopoggi/community.general that referenced this pull request Jul 17, 2023
@irozet12 @felixfontein @valeriopoggi
Fix key error for reverse zone (ansible-collections#6905) (ansible-co…
1e58a63 
…llections#6906)

* Fix key error for reverse zone (ansible-collections#6905)

* Add changelog fragment for ansible-collections#6905

* Fix changelog (6905)

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipa_dnszone fails for reverse zone
3 participants
@irozet12 @ansibullbot @felixfontein