Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

locale_gen: refactor #6903

Merged
merged 3 commits into from
Jul 15, 2023
Merged

locale_gen: refactor #6903

merged 3 commits into from
Jul 15, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jul 9, 2023

SUMMARY

Big refactor on the module.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

locale_gen

@ansibullbot
Copy link
Collaborator

cc @AugustusKling
click here for bot help

@ansibullbot ansibullbot added module module plugins plugin (any type) labels Jul 9, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 labels Jul 9, 2023
@felixfontein
Copy link
Collaborator

The good thing is that we have extensive tests for this module :-)

I'll merge this in a week if nobody objects.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 15, 2023
@felixfontein felixfontein merged commit 3a6955c into ansible-collections:main Jul 15, 2023
@patchback
Copy link

patchback bot commented Jul 15, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/3a6955cbd75e1ba199f4a38af7e7d18700816bd1/pr-6903

Backported as #6945

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 15, 2023
@russoz @patchback
locale_gen: refactor (#6903)
31252e7 
* locale_gen: refactor

* fix sanity

* add changelog frag

(cherry picked from commit 3a6955c)
@patchback patchback bot mentioned this pull request Jul 15, 2023
Merged
@felixfontein
Copy link
Collaborator

@russoz thanks!

@russoz russoz deleted the locale_gen_refactor branch July 15, 2023 12:19
felixfontein pushed a commit that referenced this pull request Jul 15, 2023
@patchback @russoz
[PR #6903/3a6955cb backport][stable-7] locale_gen: refactor (#6945)
15b950f 
locale_gen: refactor (#6903)

* locale_gen: refactor

* fix sanity

* add changelog frag

(cherry picked from commit 3a6955c)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
valeriopoggi pushed a commit to valeriopoggi/community.general that referenced this pull request Jul 17, 2023
@russoz @valeriopoggi
locale_gen: refactor (ansible-collections#6903)
e11d253 
* locale_gen: refactor

* fix sanity

* add changelog frag
@jyanesnotariado jyanesnotariado mentioned this pull request May 28, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein