Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stackdriver: deprecate module #6887

Merged
merged 4 commits into from
Jul 13, 2023
Merged

stackdriver: deprecate module #6887

merged 4 commits into from
Jul 13, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jul 7, 2023

SUMMARY

The module relies entirely on API endpoints on a hostname that no longer resolves in DNS, hence the module is now utterly useless. Example: https://event-gateway.stackdriver.com/v1/annotationevent

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

stackdriver

@ansibullbot
Copy link
Collaborator

cc @bwhaley
click here for bot help

@ansibullbot ansibullbot added docs module module plugins plugin (any type) small_patch Hopefully easy to review and removed small_patch Hopefully easy to review labels Jul 7, 2023
felixfontein
felixfontein reviewed Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@felixfontein
Copy link
Collaborator

Looks like stackdriver got bought by Google and integrated in their services (https://en.wikipedia.org/wiki/Stackdriver).

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 labels Jul 8, 2023
@felixfontein
Copy link
Collaborator

You also need to update the other places.

@russoz russoz force-pushed the deprecate-stackdriver branch from 47f951c to c90aa61 Compare July 9, 2023 03:37
@felixfontein
Copy link
Collaborator

Actually ... I think we can even do the removal in 8.0.0. For some reason I thought 8.0.0 would be the next major release, I (again) confused Ansible's versions with c.g's versions... 🤦

Whatever you prefer. Both merging this as-is (removal in 9.0.0) and adjusting the removal to 8.0.0 is fine for me.

@russoz
Copy link
Collaborator Author

russoz commented Jul 13, 2023

@felixfontein will stick with the 9.0.0, if nothing else for the consistency. The similar PR for the webfaction modules was merged with removal for 9.0.0, let's try and keep that together.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 13, 2023
@felixfontein felixfontein merged commit 065ce3a into ansible-collections:main Jul 13, 2023
@patchback
Copy link

patchback bot commented Jul 13, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/065ce3a134e99963595110cabbbbfdc7a4b60fd2/pr-6887

Backported as #6924

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks!

@patchback patchback bot mentioned this pull request Jul 13, 2023
Merged
patchback bot pushed a commit that referenced this pull request Jul 13, 2023
@russoz @patchback
stackdriver: deprecate module (#6887)
03a044e 
* stackdriver: deprecate module

* add changelog frag

* Update changelogs/fragments/6887-deprecate-stackdrive.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix removal version

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 065ce3a)
felixfontein pushed a commit that referenced this pull request Jul 13, 2023
@patchback @russoz
[PR #6887/065ce3a1 backport][stable-7] stackdriver: deprecate module (#…
a610e27 
…6924)

stackdriver: deprecate module (#6887)

* stackdriver: deprecate module

* add changelog frag

* Update changelogs/fragments/6887-deprecate-stackdrive.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix removal version

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 065ce3a)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the deprecate-stackdriver branch July 13, 2023 19:59
valeriopoggi pushed a commit to valeriopoggi/community.general that referenced this pull request Jul 17, 2023
@russoz @felixfontein @valeriopoggi
stackdriver: deprecate module (ansible-collections#6887)
92cf36e 
* stackdriver: deprecate module

* add changelog frag

* Update changelogs/fragments/6887-deprecate-stackdrive.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix removal version

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
docs module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein