Fix for get_volume_inventory #6883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
felixfontein
reviewed
Jul 7, 2023
changelogs/fragments/6883-redfish-utils-changing-variable-names-in-get-volume-inventory.yml
Outdated
Show resolved
Hide resolved
…s-in-get-volume-inventory.yml
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6947 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
* Fix for get_volume_inventory * Adding changelog fragment * Update changelogs/fragments/6883-redfish-utils-changing-variable-names-in-get-volume-inventory.yml --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit c70edfa)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6948 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
* Fix for get_volume_inventory * Adding changelog fragment * Update changelogs/fragments/6883-redfish-utils-changing-variable-names-in-get-volume-inventory.yml --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit c70edfa)
felixfontein
pushed a commit
that referenced
this pull request
Jul 15, 2023
…6947) Fix for get_volume_inventory (#6883) * Fix for get_volume_inventory * Adding changelog fragment * Update changelogs/fragments/6883-redfish-utils-changing-variable-names-in-get-volume-inventory.yml --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit c70edfa) Co-authored-by: TSKushal <44438079+TSKushal@users.noreply.github.com>
felixfontein
pushed a commit
that referenced
this pull request
Jul 15, 2023
…6948) Fix for get_volume_inventory (#6883) * Fix for get_volume_inventory * Adding changelog fragment * Update changelogs/fragments/6883-redfish-utils-changing-variable-names-in-get-volume-inventory.yml --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit c70edfa) Co-authored-by: TSKushal <44438079+TSKushal@users.noreply.github.com>
valeriopoggi
pushed a commit
to valeriopoggi/community.general
that referenced
this pull request
Jul 17, 2023
* Fix for get_volume_inventory * Adding changelog fragment * Update changelogs/fragments/6883-redfish-utils-changing-variable-names-in-get-volume-inventory.yml --------- Co-authored-by: Kushal <t-s.kushal@hpe.com> Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixing an issue caused due to PR 6719. The "data" variable was getting replaced in the elif block on line 915 and was causing an issue on line 937 when getting the Volumes url.
ISSUE TYPE
COMPONENT NAME
redfish_utils.py