Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding 'Links' to the parameter list for data retrieved from get_disk_inventory #6819

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Adding 'Links' to the parameter list for data retrieved from get_disk_inventory #6819

merged 7 commits into from
Aug 21, 2023

Conversation

TSKushal
Copy link
Contributor

SUMMARY
Adding 'Links' to the parameter list for data retrieved from get_disk_inventory

ISSUE TYPE

  • Feature Pull Request

COMPONENT NAME
redfish_utils.py

@ansibullbot
Copy link
Collaborator

cc @Bhavya06 @jyundt @mraineri @rajeevkallur @renxulei @tomasg2012 @xmadsen
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type) small_patch Hopefully easy to review labels Jun 30, 2023
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Jun 30, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 labels Jun 30, 2023
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jul 15, 2023
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Jul 19, 2023
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jul 27, 2023
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Jul 28, 2023
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Aug 8, 2023
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Aug 18, 2023
@mraineri
Copy link
Contributor

Besides the changelog fragment, everything else looks good to me.

@TSKushal @felixfontein
Update changelogs/fragments/6819-redfish-utils-add-links-parameter-fo…
4ec4774 
…r-get_disk_inventory.yml


Agreed

Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Aug 21, 2023
@felixfontein felixfontein merged commit 17dce5a into ansible-collections:main Aug 21, 2023
@patchback
Copy link

patchback bot commented Aug 21, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/17dce5a28851e85746a7ab9f85499c86a8b8b6f0/pr-6819

Backported as #7141

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@TSKushal thanks for your contribution!
@mraineri thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Aug 21, 2023
@TSKushal @patchback
Adding 'Links' to the parameter list for data retrieved from get_disk…
a2c2633 
…_inventory (#6819)

* Adding 'Links' parameter to be retrieved from get_disk_inventory

* Adding changelog fragment

* Updating as per PR suggestions

* Updating to return volumes as a list of strings

* Updating code to retrieve only volumes under the Links parameter

* Updating changelog fragment

* Update changelogs/fragments/6819-redfish-utils-add-links-parameter-for-get_disk_inventory.yml

Agreed

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Kushal <t-s.kushal@hpe.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 17dce5a)
@patchback patchback bot mentioned this pull request Aug 21, 2023
Merged
felixfontein pushed a commit that referenced this pull request Aug 21, 2023
@patchback @TSKushal
[PR #6819/17dce5a2 backport][stable-7] Adding 'Links' to the paramete…
0c2d1ed 
…r list for data retrieved from get_disk_inventory (#7141)

Adding 'Links' to the parameter list for data retrieved from get_disk_inventory (#6819)

* Adding 'Links' parameter to be retrieved from get_disk_inventory

* Adding changelog fragment

* Updating as per PR suggestions

* Updating to return volumes as a list of strings

* Updating code to retrieve only volumes under the Links parameter

* Updating changelog fragment

* Update changelogs/fragments/6819-redfish-utils-add-links-parameter-for-get_disk_inventory.yml

Agreed

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Kushal <t-s.kushal@hpe.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 17dce5a)

Co-authored-by: TSKushal <44438079+TSKushal@users.noreply.github.com>
etrombly pushed a commit to etrombly/community.general that referenced this pull request Oct 25, 2023
@TSKushal @TSKushalHPE @felixfontein
Adding 'Links' to the parameter list for data retrieved from get_disk…
7782eb8 
…_inventory (ansible-collections#6819)

* Adding 'Links' parameter to be retrieved from get_disk_inventory

* Adding changelog fragment

* Updating as per PR suggestions

* Updating to return volumes as a list of strings

* Updating code to retrieve only volumes under the Links parameter

* Updating changelog fragment

* Update changelogs/fragments/6819-redfish-utils-add-links-parameter-for-get_disk_inventory.yml

Agreed

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Kushal <t-s.kushal@hpe.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraineri mraineri mraineri left review comments

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TSKushal @ansibullbot @mraineri @felixfontein @TSKushalHPE