Module proxmox_kvm restarted state bug fix

[juan210012]

SUMMARY

Previously, the restarted state used both stop and start vm functions to restart a vm. In some cases, the start_vm function starts before the vm on Proxmox finishes shutting down. This causes the start_vm function to return saying that the vm is already running. The vm ends up in the stopped state and the output will wrongly display that the restart was successful.
This change introduces the a new function that utilizes the Proxmox reboot endpoint instead for a more reliable method of restarting a vm.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

proxmox_kvm

ADDITIONAL INFORMATION

To reproduce this bug, have a running vm on Proxmox with these parameters set for High Availability:

Then run an Ansible playbook with the state set to restarted.
There may be other vm configurations in which the restart fails but this is the one I have found to fail often.

This change does not produce a different output.

[ansibullbot]

cc @Ajpantuso @Thulium-Drake @UnderGreen @helldorado @joshainglis @karmab @tleguern
click here for bot help

[patchback]

Backport to stable-6: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 3571df8 on top of patchback/backports/stable-6/3571df837d7c7f2c0aa5d6b02618635b0e4454cb/pr-6773

Backporting merged PR #6773 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible-collections/community.general.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-6/3571df837d7c7f2c0aa5d6b02618635b0e4454cb/pr-6773 upstream/stable-6

4. Now, cherry-pick PR Module proxmox_kvm restarted state bug fix #6773 contents into that branch:

   $ git cherry-pick -x 3571df837d7c7f2c0aa5d6b02618635b0e4454cb

   If it'll yell at you with something like fatal: Commit 3571df837d7c7f2c0aa5d6b02618635b0e4454cb is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 3571df837d7c7f2c0aa5d6b02618635b0e4454cb

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Module proxmox_kvm restarted state bug fix #6773 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-6/3571df837d7c7f2c0aa5d6b02618635b0e4454cb/pr-6773

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/3571df837d7c7f2c0aa5d6b02618635b0e4454cb/pr-6773

Backported as #6797

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@juan210012 thanks for your contribution!
@UnderGreen thanks for reviewing!