Keycloak authentication provider ID choices #6763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
Jun 25, 2023
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6799 🤖 @patchback |
|
@Skrekulko thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
* refac: provider id choices * feat: minor changes fragment * Update changelogs/fragments/6763-keycloak-auth-provider-choices.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Skrekulko <Skrekulko@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a53bf9d)
felixfontein
pushed a commit
that referenced
this pull request
Jun 28, 2023
…er ID choices (#6799) Keycloak authentication provider ID choices (#6763) * refac: provider id choices * feat: minor changes fragment * Update changelogs/fragments/6763-keycloak-auth-provider-choices.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Skrekulko <Skrekulko@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit a53bf9d) Co-authored-by: Skrekulko <111891715+Skrekulko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The provider ID according to Keycloak can only be basic-flow or client-flow, so I introduced choices for it.
ISSUE TYPE
COMPONENT NAME
keycloak_authentication
ADDITIONAL INFORMATION
This is a separate PR for minor changes I introduced in #6734. I did so, in order to have the bugfix backported.