Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6687/e06a0e22 backport][stable-7] keycloak_client_rolemapping.py: add support for subgroups #6723

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 18, 2023

This is a backport of PR #6687 as merged into main (e06a0e2).

SUMMARY

There was a missing parents parameter which prevented my ansible scripts from mapping roles to subgroups

The fix was easy, as everything was already implemented and only missing parents parameter needed to be added.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

keycloak_client_rolemapping

ADDITIONAL INFORMATION

I needed to map a role to a subgroup but I could not because there was a missing parameter parents in the python script. Adding it solved the issue.

* keycloak_client_rolemapping.py: add support for subgroups

* Add PR number after creating a PR to 6687-support-subgroups-for-keycloak-client-rolemapping.yml

* Update changelogs/fragments/6687-support-subgroups-for-keycloak-client-rolemapping.yml

Add missing URL

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/keycloak_client_rolemapping.py

Set a correct version_added (previously it was a copy-paste)

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/keycloak_client_rolemapping.py

Fix typo after copy-paste

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/keycloak_client_rolemapping.py

Fix typo after copy-paste

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/keycloak_client_rolemapping.py

Fix typo after copy-paste

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Mikhail Putilov <Mikhail.Putilov@dimoco.eu>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit e06a0e2)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit labels Jun 18, 2023
@felixfontein felixfontein merged commit 5c7b103 into stable-7 Jun 18, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-7/e06a0e22f76a9fc184d33564b6a3689b5a814ae0/pr-6687 branch June 18, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants