gitlab_group => Make most options optional #6712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog fragment? Thanks.
Also, instead of having an if for every entry, why not modify create_group() to filter out all None values?
|
+1 for checking Btw, this closes #4577 and #5806. (but as we discussed in #4577, since GitLab doesn't like receiving null attributes there will be another 15+ attributes from that API that would need to be added the same way eventually) |
|
I added a filter to the create_group function instead. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@felixfontein @nejch : Are these changed good ? |
This comment was marked as outdated.
This comment was marked as outdated.
changelogs/fragments/6712-gitlab_group-filtered-for-none-values.yml
Outdated
Show resolved
Hide resolved
…s.yml Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
|
Committed the suggestions. Thanks @felixfontein ! |
felixfontein
approved these changes
Jun 18, 2023
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6724 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 18, 2023
* Make most options optional as they should be * Add filter to create_group instead * Remove whitespace * Add changelog fragment * Added description and extension to fragment * Update changelogs/fragments/6712-gitlab_group-filtered-for-none-values.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/gitlab_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Make Python 2.6 compatible. * Another shot at compatibility. --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit e85b008)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6725 🤖 @patchback |
|
@Intellium thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Jun 18, 2023
* Make most options optional as they should be * Add filter to create_group instead * Remove whitespace * Add changelog fragment * Added description and extension to fragment * Update changelogs/fragments/6712-gitlab_group-filtered-for-none-values.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/gitlab_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Make Python 2.6 compatible. * Another shot at compatibility. --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit e85b008)
felixfontein
pushed a commit
that referenced
this pull request
Jun 18, 2023
…ons optional (#6725) gitlab_group => Make most options optional (#6712) * Make most options optional as they should be * Add filter to create_group instead * Remove whitespace * Add changelog fragment * Added description and extension to fragment * Update changelogs/fragments/6712-gitlab_group-filtered-for-none-values.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/gitlab_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Make Python 2.6 compatible. * Another shot at compatibility. --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit e85b008) Co-authored-by: Intellium <w.moeken@moeken.eu>
felixfontein
pushed a commit
that referenced
this pull request
Jun 18, 2023
…ons optional (#6724) gitlab_group => Make most options optional (#6712) * Make most options optional as they should be * Add filter to create_group instead * Remove whitespace * Add changelog fragment * Added description and extension to fragment * Update changelogs/fragments/6712-gitlab_group-filtered-for-none-values.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/gitlab_group.py Co-authored-by: Felix Fontein <felix@fontein.de> * Make Python 2.6 compatible. * Another shot at compatibility. --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit e85b008) Co-authored-by: Intellium <w.moeken@moeken.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR changes the gitlab_group module to make most options optional, as they should be according to the gitlab API documentation. This PR also ensures compatibility with Gitlab v16 as current module behaviour is non-functional with Gitlab v16.
Closes #4577
Closes #5806
ISSUE TYPE
COMPONENT NAME
gitlab_group
ADDITIONAL INFORMATION
Current module behaviour is to include parameters in the API call to gitlab even if they're not set. This results in the API call including 'nil' values for these parameters. This still worked up until Gitlab v15.11.4.
Gitlab v16 currently breaks on this behaviour. This pull request ensures API parameters are only included when they're actually set, or if they are mandatory.