rhsm_repository: deprecate "state=present" and "state=absent" #6673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"state=present" is broken, and acts like "disabled"; also, the subscription repositories cannot be really "added" or "removed", which is what "present" and "absent" would imply, but only enabled or disabled. Hence, deprecate both these states, slating them for removal in community.general 10.0.0.
6335e9e to
5edc4ba
Compare
felixfontein
approved these changes
Jun 11, 2023
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6675 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 11, 2023
"state=present" is broken, and acts like "disabled"; also, the subscription repositories cannot be really "added" or "removed", which is what "present" and "absent" would imply, but only enabled or disabled. Hence, deprecate both these states, slating them for removal in community.general 10.0.0. (cherry picked from commit 2dbe529)
|
@ptoscano thanks! |
felixfontein
pushed a commit
that referenced
this pull request
Jun 11, 2023
…ate=present" and "state=absent" (#6675) rhsm_repository: deprecate "state=present" and "state=absent" (#6673) "state=present" is broken, and acts like "disabled"; also, the subscription repositories cannot be really "added" or "removed", which is what "present" and "absent" would imply, but only enabled or disabled. Hence, deprecate both these states, slating them for removal in community.general 10.0.0. (cherry picked from commit 2dbe529) Co-authored-by: Pino Toscano <ptoscano@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
state=presentis broken, and acts likedisabled; also, the subscription repositories cannot be really "added" or "removed", which is whatpresentandabsentwould imply, but only enabled or disabled. Hence, deprecate both these states, slating them for removal in community.general 10.0.0.ISSUE TYPE
COMPONENT NAME
rhsm_repository