redhat_subscription: deprecate "pool" #6650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "pool" option is slower to use, and the regexp may expand to broader results than wanted. Because of that, deprecate it in favour of the "pool_ids" options (which is much better), slating it for removal in community.general 10.0.0.
ea76a86 to
648cb2d
Compare
felixfontein
approved these changes
Jun 9, 2023
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6657 🤖 @patchback |
|
@ptoscano thanks! |
patchback bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
The "pool" option is slower to use, and the regexp may expand to broader results than wanted. Because of that, deprecate it in favour of the "pool_ids" options (which is much better), slating it for removal in community.general 10.0.0. (cherry picked from commit 61b8897)
felixfontein
pushed a commit
that referenced
this pull request
Jun 9, 2023
… "pool" (#6657) redhat_subscription: deprecate "pool" (#6650) The "pool" option is slower to use, and the regexp may expand to broader results than wanted. Because of that, deprecate it in favour of the "pool_ids" options (which is much better), slating it for removal in community.general 10.0.0. (cherry picked from commit 61b8897) Co-authored-by: Pino Toscano <ptoscano@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
pooloption is slower to use, and the regexp may expand to broader results than wanted. Because of that, deprecate it in favour of thepool_idsoptions (which is much better), slating it for removal in community.general 10.0.0.ISSUE TYPE
COMPONENT NAME
redhat_subscription