Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MH mh/mixins/deps.py: prevent deprecation warning when no deps are specified #6644

Merged
merged 4 commits into from
Jun 9, 2023
Merged

MH mh/mixins/deps.py: prevent deprecation warning when no deps are specified #6644

merged 4 commits into from
Jun 9, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jun 8, 2023

SUMMARY

Add test to deprecated DependencyMixin so that the deprecation warning only pops up when dependencies are actually specified.

Fixes #6639

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/mh/mixins/deps.py

@ansibullbot ansibullbot added bug This issue/PR relates to a bug integration tests/integration module_utils module_utils plugins plugin (any type) tests tests labels Jun 8, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 labels Jun 9, 2023
felixfontein
felixfontein reviewed Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add a changelog fragment?

(The third-party check failure is unrelated.)

@russoz
Copy link
Collaborator Author

russoz commented Jun 9, 2023

Sure thing - busy day, I thought I had done it already.

@felixfontein
Copy link
Collaborator

No worries :) Thanks!

@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jun 9, 2023
@felixfontein felixfontein merged commit 494909a into ansible-collections:main Jun 9, 2023
@patchback
Copy link

patchback bot commented Jun 9, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/494909aba535d3f35d2f3aeca0129cd5cb97efcf/pr-6644

Backported as #6653

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 9, 2023
@russoz @patchback
MH mh/mixins/deps.py: prevent deprecation warning when no deps are sp…
02af572 
…ecified (#6644)

* MH mh/mixins/deps.py: prevent deprecation warning when no deps are specified

* rollback empty "patch" on license markers to prevent test error

* disable test in ansible 2.12

* add changelog frag

(cherry picked from commit 494909a)
@patchback patchback bot mentioned this pull request Jun 9, 2023
Merged
@felixfontein
Copy link
Collaborator

@russoz thanks for fixing this!

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 9, 2023
felixfontein pushed a commit that referenced this pull request Jun 9, 2023
@patchback @russoz
[PR #6644/494909ab backport][stable-7] MH mh/mixins/deps.py: prevent …
1f51875 
…deprecation warning when no deps are specified (#6653)

MH mh/mixins/deps.py: prevent deprecation warning when no deps are specified (#6644)

* MH mh/mixins/deps.py: prevent deprecation warning when no deps are specified

* rollback empty "patch" on license markers to prevent test error

* disable test in ansible 2.12

* add changelog frag

(cherry picked from commit 494909a)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the 6639-blacklist-dependencymixin branch June 9, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug integration tests/integration module_utils module_utils plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The DependencyMixin is being deprecated.
3 participants
@russoz @felixfontein @ansibullbot