Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ini_file: removing required=true for 'section' option #6404

Merged
merged 1 commit into from
Apr 23, 2023
Merged

ini_file: removing required=true for 'section' option #6404

merged 1 commit into from
Apr 23, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Apparently null/None was always a valid parameter. ansible-core only allowed this due to a bug that got fixed, so specifying release: null no longer works with that fix (ansible/ansible#79677).

(This also breaks nightly CI.)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ini_file

@ansibullbot
Copy link
Collaborator

cc @jpmens @noseka1
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels Apr 23, 2023
@felixfontein felixfontein merged commit e49c6a3 into ansible-collections:main Apr 23, 2023
@patchback
Copy link

patchback bot commented Apr 23, 2023 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/e49c6a339ea76272c34f711fe055594682252db8/pr-6404

Backported as #6410

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the ci3 branch April 23, 2023 14:51
patchback bot pushed a commit that referenced this pull request Apr 23, 2023
@felixfontein @patchback
ini_file: removing required=true for 'section' option (#6404)
b7aae86 
Fix ini_file by removing required=true for 'section' option.

(cherry picked from commit e49c6a3)
@patchback patchback bot mentioned this pull request Apr 23, 2023
Merged
@patchback
Copy link

patchback bot commented Apr 23, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/e49c6a339ea76272c34f711fe055594682252db8/pr-6404

Backported as #6411

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 23, 2023
@felixfontein @patchback
ini_file: removing required=true for 'section' option (#6404)
b8374a4 
Fix ini_file by removing required=true for 'section' option.

(cherry picked from commit e49c6a3)
@patchback patchback bot mentioned this pull request Apr 23, 2023
Merged
felixfontein added a commit that referenced this pull request Apr 23, 2023
@patchback @felixfontein
[PR #6404/e49c6a33 backport][stable-5] ini_file: removing required=tr…
3db3608 
…ue for 'section' option (#6410)

ini_file: removing required=true for 'section' option (#6404)

Fix ini_file by removing required=true for 'section' option.

(cherry picked from commit e49c6a3)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Apr 23, 2023
@patchback @felixfontein
[PR #6404/e49c6a33 backport][stable-6] ini_file: removing required=tr…
5fe1091 
…ue for 'section' option (#6411)

ini_file: removing required=true for 'section' option (#6404)

Fix ini_file by removing required=true for 'section' option.

(cherry picked from commit e49c6a3)

Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein mentioned this pull request Nov 19, 2023
Merged
This was referenced Nov 23, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @ansibullbot