rhsm_release: removing required=true for 'release' option #6401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cnsnyder @ptoscano @seandst |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #6408 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 23, 2023
Fix rhsm_release by removing required=true for 'release' option. (cherry picked from commit 486c47f)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6409 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 23, 2023
Fix rhsm_release by removing required=true for 'release' option. (cherry picked from commit 486c47f)
richm
added a commit
to richm/linux-system-roles-rhc
that referenced
this pull request
Jun 2, 2023
Do not set release if rhc_release is none. See ansible-collections/community.general#6401 for details.
ptoscano
added a commit
to ptoscano/linux-system-roles-rhc
that referenced
this pull request
Jun 5, 2023
- we need to update the community.general dependency to >= 6.6.0 to make the role working with with ansible-core >= 2.15 (adapting to a change in rhsm_release [1]) - unpin the community.general requirement means breaking the registration of Fedora managed nodes, as SELinux policies need to be adapted [2] - [2] is temporarily broken by a dnf bug in Rawhide [3] Since registration is already broken for people using the upstream redhat_subscription module in community.general, and registering Fedora system is a corner case, let's temporarily stop supporting Fedora systems. This will allow us to fix the role to make it usable with ansible-core >= 2.15; the support for Fedora will be added back when the Fedora SELinux policy will be fixed. [1] ansible-collections/community.general#6401 [2] fedora-selinux/selinux-policy#1726 [3] https://bugzilla.redhat.com/show_bug.cgi?id=2210694 Signed-off-by: Pino Toscano <ptoscano@redhat.com>
richm
pushed a commit
to linux-system-roles/rhc
that referenced
this pull request
Jun 5, 2023
- we need to update the community.general dependency to >= 6.6.0 to make the role working with with ansible-core >= 2.15 (adapting to a change in rhsm_release [1]) - unpin the community.general requirement means breaking the registration of Fedora managed nodes, as SELinux policies need to be adapted [2] - [2] is temporarily broken by a dnf bug in Rawhide [3] Since registration is already broken for people using the upstream redhat_subscription module in community.general, and registering Fedora system is a corner case, let's temporarily stop supporting Fedora systems. This will allow us to fix the role to make it usable with ansible-core >= 2.15; the support for Fedora will be added back when the Fedora SELinux policy will be fixed. [1] ansible-collections/community.general#6401 [2] fedora-selinux/selinux-policy#1726 [3] https://bugzilla.redhat.com/show_bug.cgi?id=2210694 Signed-off-by: Pino Toscano <ptoscano@redhat.com>
richm
added a commit
to richm/linux-system-roles-rhc
that referenced
this pull request
Jun 5, 2023
Do not set release if rhc_release is none. See ansible-collections/community.general#6401 for details.
ptoscano
added a commit
to ptoscano/linux-system-roles-rhc
that referenced
this pull request
Jun 6, 2023
This version contains a number of features and fixes that greatly help this role; while the role was able so far to work with older versions, let's require a recent version so it is possible to drop workarounds. In particular, we need to require 6.6.0 so we can adapt to the new behaviour of rhsm_release [1], needed to run with ansible-core 2.15. [1] ansible-collections/community.general#6401 Signed-off-by: Pino Toscano <ptoscano@redhat.com>
richm
pushed a commit
to linux-system-roles/rhc
that referenced
this pull request
Jun 6, 2023
This version contains a number of features and fixes that greatly help this role; while the role was able so far to work with older versions, let's require a recent version so it is possible to drop workarounds. In particular, we need to require 6.6.0 so we can adapt to the new behaviour of rhsm_release [1], needed to run with ansible-core 2.15. [1] ansible-collections/community.general#6401 Signed-off-by: Pino Toscano <ptoscano@redhat.com>
richm
added a commit
to richm/linux-system-roles-rhc
that referenced
this pull request
Jun 6, 2023
The way the new version of rhsm_release works is - if the `release` parameter is present, set the release to the given value. If there is no `release` parameter, unset the release. If the user does not set `rhc_release`, then it will be `null`, and calling the rhsm_release module will be skipped. See ansible-collections/community.general#6401 for details. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-rhc
that referenced
this pull request
Jun 6, 2023
The way the new version of rhsm_release works is this: - if the `release` parameter is present, set the release to the given value. - If there is no `release` parameter, unset the release. If the user does not set `rhc_release`, or if the user sets it to `omit` then it will be `null`, and calling the rhsm_release module will be skipped. See ansible-collections/community.general#6401 for details. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
ptoscano
pushed a commit
to linux-system-roles/rhc
that referenced
this pull request
Jun 6, 2023
The way the new version of rhsm_release works is this: - if the `release` parameter is present, set the release to the given value. - If there is no `release` parameter, unset the release. If the user does not set `rhc_release`, or if the user sets it to `omit` then it will be `null`, and calling the rhsm_release module will be skipped. See ansible-collections/community.general#6401 for details. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Apparently
null/Nonewas always a valid parameter. ansible-core only allowed this due to a bug that got fixed, so specifyingrelease: nullno longer works with that fix (ansible/ansible#79677).(This also breaks nightly CI.)
ISSUE TYPE
COMPONENT NAME
rhsm_release