Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab modules: minor refactor #6384

Merged
merged 6 commits into from
May 8, 2023
Merged

gitlab modules: minor refactor #6384

merged 6 commits into from
May 8, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Apr 20, 2023

SUMMARY

Refactor function vars_to_variables used in both modules gitlab_group_variable and gitlab_project_variable to the gitlab module utils.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

plugins/module_utils/gitlab.py
plugins/modules/gitlab_group_variable.py
plugins/modules/gitlab_project_variable.py

@ansibullbot
Copy link
Collaborator

cc @Lunik @Shaps @dj-wasabi @lgatellier @markuman @marwatk @metanovii @nejch @scodeman @sh0shin @suukit @waheedi @zanssa
click here for bot help

@ansibullbot ansibullbot added gitlab module module module_utils module_utils plugins plugin (any type) labels Apr 20, 2023
felixfontein
felixfontein reviewed Apr 20, 2023
View reviewed changes
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Apr 20, 2023
@russoz @felixfontein
Update plugins/module_utils/gitlab.py
911307a 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 20, 2023
russoz and others added 2 commits April 21, 2023 00:22
@russoz @felixfontein
Update plugins/module_utils/gitlab.py
0536569 
Co-authored-by: Felix Fontein <felix@fontein.de>
@russoz
update changelog frag
4b44257
@ansibullbot ansibullbot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Apr 20, 2023
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Apr 20, 2023
@felixfontein
Copy link
Collaborator

Did you try running this code to see whether it still works as expected?

@russoz
Copy link
Collaborator Author

russoz commented Apr 24, 2023

No I have not. Feel free to sit this one out of the 6.6.0 release to get more review time.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label May 5, 2023
@felixfontein
Copy link
Collaborator

@markuman is your thumb up for the PR some kind of review? :)

@markuman
Copy link
Member

markuman commented May 7, 2023

I can checkout the PR tomorrow and run it in the wild. But it looks good to me.

@felixfontein
Copy link
Collaborator

@markuman would be great if you could do that!

@markuman
Copy link
Member

markuman commented May 8, 2023

I made some short tests. Works as expected.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 8, 2023
@felixfontein felixfontein merged commit febe7a2 into ansible-collections:main May 8, 2023
@felixfontein
Copy link
Collaborator

@russoz thanks for the refactoring!
@markuman thanks for reviewing and testing!

@russoz russoz deleted the gitlab-group-variable-refactor branch May 8, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
gitlab module_utils module_utils module module plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@russoz @ansibullbot @felixfontein @markuman