Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldap moduls: add optional ca_cert_file option #6185

Merged
merged 4 commits into from
Mar 22, 2023
Merged

ldap moduls: add optional ca_cert_file option #6185

merged 4 commits into from
Mar 22, 2023

Conversation

rekup
Copy link
Contributor

@rekup rekup commented Mar 14, 2023

SUMMARY

This PR adds a ca_cert_file option to the ldap modules. This option can be used to specify a ca certificate used to verify ldap tls connections.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ldap modules

ADDITIONAL INFORMATION

I wasn't sure how to name the changelog fragment, since this PR does not address an existing issue

@rekup rekup changed the title add ca_cert_file option ldap moduls: add optional ca_cert_file option Mar 14, 2023
@ansibullbot ansibullbot added docs_fragments docs_fragments plugin (shared docs) feature This issue/PR relates to a feature request module_utils module_utils needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Mar 14, 2023
@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Mar 14, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Mar 14, 2023
felixfontein
felixfontein reviewed Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

plugins/doc_fragments/ldap.py Outdated Show resolved Hide resolved
plugins/doc_fragments/ldap.py Outdated Show resolved Hide resolved
plugins/module_utils/ldap.py Outdated Show resolved Hide resolved
@rekup @felixfontein
Apply suggestions from code review
536a8c5 
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
felixfontein approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If nobody objects, I'll merge this in ~a week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 22, 2023
@felixfontein felixfontein merged commit 512bf4b into ansible-collections:main Mar 22, 2023
@patchback
Copy link

patchback bot commented Mar 22, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/512bf4b77f86d8e3875ed958d179d38745ba00cc/pr-6185

Backported as #6217

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 22, 2023
@rekup @patchback
ldap moduls: add optional ca_cert_file option (#6185)
ce068c7 
* add ca_cert_file option

* fix pr url

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* update parameter name

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 512bf4b)
@patchback patchback bot mentioned this pull request Mar 22, 2023
Merged
@felixfontein
Copy link
Collaborator

@rekup thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Mar 22, 2023
@patchback @rekup
[PR #6185/512bf4b7 backport][stable-6] ldap moduls: add optional ca_c…
31a1c8e 
…ert_file option (#6217)

ldap moduls: add optional ca_cert_file option (#6185)

* add ca_cert_file option

* fix pr url

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* update parameter name

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 512bf4b)

Co-authored-by: Reto Kupferschmid <kupferschmid@puzzle.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
docs_fragments docs_fragments plugin (shared docs) feature This issue/PR relates to a feature request module_utils module_utils plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekup @felixfontein @ansibullbot